Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug saving to BytesIO on Renderer #1560

Merged
merged 1 commit into from Jun 17, 2017

Conversation

Projects
None yet
2 participants
@philippjfr
Copy link
Contributor

philippjfr commented Jun 17, 2017

Small fix ensuring that Renderer.save can save to BytesIO object when exporting widgets. Fixes #1381.

@philippjfr philippjfr added the bug label Jun 17, 2017

@jlstevens

This comment has been minimized.

Copy link
Contributor

jlstevens commented Jun 17, 2017

Glad this is a simpler fix than I anticipated. Merge?

@philippjfr

This comment has been minimized.

Copy link
Contributor Author

philippjfr commented Jun 17, 2017

Yes, go for it.

@jlstevens jlstevens merged commit cb97594 into master Jun 17, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.2%) to 79.271%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the bytes_io_fix branch Jun 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.