Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous stream fixes #2256

Merged
merged 3 commits into from Jan 11, 2018

Conversation

Projects
None yet
3 participants
@philippjfr
Copy link
Contributor

philippjfr commented Jan 11, 2018

Includes three small fixes:

  • AreaPlot no longer allows streaming data (because the glyph type doesn't allow it)
  • TablePlot initializes stream callbacks
  • When a data source is shared across multiple plots callbacks are reinitialized
@philippjfr

This comment has been minimized.

Copy link
Contributor Author

philippjfr commented Jan 11, 2018

Ready for review/merge. All uncontroversial small fixes.

@jlstevens

This comment has been minimized.

Copy link
Contributor

jlstevens commented Jan 11, 2018

Looks good to me. Merging.

@jlstevens jlstevens merged commit 1746f57 into master Jan 11, 2018

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.007%) to 81.248%
Details
s3-reference-data-cache Test data is cached.
Details
@ayoungs

This comment has been minimized.

Copy link

ayoungs commented Jan 12, 2018

InteractiveBoxTestApp.py.zip
This small test of a stream and Overlaying a bounds on an Image still doesn't work.
I thought it might be related.

@philippjfr

This comment has been minimized.

Copy link
Contributor Author

philippjfr commented Jan 12, 2018

@ayoungs Are you using HoloViews master? It does work for me.

@ayoungs

This comment has been minimized.

Copy link

ayoungs commented Jan 12, 2018

Now I have it working, using the correct install process and it works as expected! Thank you!

@philippjfr

This comment has been minimized.

Copy link
Contributor Author

philippjfr commented Jan 12, 2018

We'll have to have a 1.9.3 bug fix release asap.

@philippjfr philippjfr deleted the misc_streams_fixes branch Jan 13, 2018

philippjfr added a commit that referenced this pull request Feb 9, 2018

@philippjfr philippjfr added this to the 1.9.3 milestone Feb 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.