Added log option to histogram operation #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlstevens
reviewed
Oct 12, 2016
| @@ -478,6 +478,9 @@ class histogram(ElementOperation): | |||
| individually = param.Boolean(default=True, doc=""" | |||
| Specifies whether the histogram will be rescaled for each Raster in a UniformNdMapping.""") | |||
|
|
|||
| log = param.Boolean(default=False, doc=""" | |||
| Whether to apply log scaling """) | |||
There was a problem hiding this comment.
I would at least mention that it is log10....
There was a problem hiding this comment.
True, that's what logspace uses, but it should still be explained.
|
Other than a small comment about the docstring, this PR looks fine and I am happy to merge. |
philippjfr
force-pushed
the
hist_fixes
branch
from
f74ed44
to
cdd8292
Compare
|
Other than one unrelated test failure, the tests seem to be ok. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a log option to the histogram operation, which automatically generates logarithmic sampling for the histogram bins. Also includes a small fix to fix bokeh histograms with inverted axes.