Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added log option to histogram operation #929

Merged
merged 3 commits into from Oct 12, 2016
Merged

Added log option to histogram operation #929

merged 3 commits into from Oct 12, 2016

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Oct 12, 2016

This adds a log option to the histogram operation, which automatically generates logarithmic sampling for the histogram bins. Also includes a small fix to fix bokeh histograms with inverted axes.

@@ -478,6 +478,9 @@ class histogram(ElementOperation):
individually = param.Boolean(default=True, doc="""
Specifies whether the histogram will be rescaled for each Raster in a UniformNdMapping.""")

log = param.Boolean(default=False, doc="""
Whether to apply log scaling """)

This comment has been minimized.

@jlstevens

jlstevens Oct 12, 2016
Contributor

I would at least mention that it is log10....

This comment has been minimized.

@philippjfr

philippjfr Oct 12, 2016
Author Member

True, that's what logspace uses, but it should still be explained.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Oct 12, 2016

Other than a small comment about the docstring, this PR looks fine and I am happy to merge.

@philippjfr philippjfr force-pushed the hist_fixes branch from f74ed44 to cdd8292 Oct 12, 2016
@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Oct 12, 2016

Other than one unrelated test failure, the tests seem to be ok. Merging.

@jlstevens jlstevens merged commit 68fa72a into master Oct 12, 2016
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr philippjfr deleted the hist_fixes branch Oct 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants