Fixes #2041: Improved performance of and cleaned up equality test for CIM objects #2092
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second stage of addressing issue #2041, in which the actual performance improvement gets implemented.
Original equality performance:
Improved equality performance:
As a result, this change is not a significant performance improvement, but it did clean up the code and eliminated the old comparator-based logic.
Update related to Karl's suggestion in a review comment to merge 4 lines of conditional into an expression:
This makes the improvement slightly better. Note that there are still variations in the measured result:
With the original code (4 lines of conditional):
Latest code in this PR (4 lines condensed into one expression):