fix issue #678-add-class-filters #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KSchopmeyer
force-pushed
the
ks/#678-add-classfilters
branch
from
a56db12
to
4f2c840
Compare
Adds the --deprecated filter to the same commands as the other filters and extends the filter search to that the qualifiers are inspected for all class elements defined in the scope for the defined filter. Thus, an experimental qualifier on a property, method, or parameter will now be equal to the same qualifier at the class level. Modifies the filter options definition in each command to group the qualifier filters so that they can be applied to each command as a single line and the grouping is defined in _common_options.py NOTE: The logic for multiple filters is effectively anding of the conditions so that --association and --indication is for both the association and indication filter and --association --no-indication finds classes that have the association qualifier but not the indication qualifier. The code was refactored to make extension to other filters easier in the future. Added more options to the test mof qualifierfilters.mof and extended the tests.
KSchopmeyer
force-pushed
the
ks/#678-add-classfilters
branch
from
4f2c840
to
694d136
Compare
andy-maier
approved these changes
Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the --deprecated filter to the same commands as the other filters
and extends the filter search to that the qualifiers are inspected
for all class elements defined in the scope for the defined filter.
Thus, an experimental qualifier on a property, method, or parameter
will now be equal to the same qualifier at the class level.
NOTE: The logic for multiple filters is effectively anding of
the conditions so that --association and --indication is for both
the association and indication filter and --association --no-indication
finds classes that have the association qualifier but not the
indication qualifier.
The code was refactored to make extension to other filters easier in
the future.
Added more options to the test mof qualifierfilters.mof and extended
the tests.