Correcting to right multiply for diffpy #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Correcting to right multiply for diffpy
about: This is a bugfix for #28
Release Notes
What does this PR do? Please describe and/or link to an open issue.
As detailed in the associated issue, diffpy provides a rotation of the form:
Ans = std @ BR (1)where std is a known 3x3 matrix and BR is a user defined 3 by 3 matrix. Our code works on the assumption that a solution of the form
Ans = Rotation @ Basis (2)To tie these two ends together we set
BR = std^{-1} @ Rotation @ stdwhich when subbed into equation (1) produces
Ans = (std @ std^{-1}) @ Rotation @ stdwhich corresponds with (2)