Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sum Lambert projections from asymmetric positions in EMsoft plugin #255

Merged
merged 1 commit into from
Nov 30, 2020

Conversation

hakonanes
Copy link
Member

Signed-off-by: Håkon Wiik Ånes hwaanes@gmail.com

Description of the change

Progress of the PR

Minimal example of the bug fix or new feature

Reading Lambert projections from EMsoft's master pattern files with a crystal structure with multiple asymmetric atom positions now sums the Lambert projections per energy bin correctly in the IO plugin

>>> import kikuchipy as kp
>>> mp = kp.load("master_pattern.h5", projection="lambert")

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    the unreleased section in doc/changelog.rst.

Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
@hakonanes hakonanes added the bug Something isn't working label Nov 30, 2020
@hakonanes hakonanes added this to the v0.3.0 milestone Nov 30, 2020
@hakonanes hakonanes self-assigned this Nov 30, 2020
@hakonanes hakonanes merged commit 1cb03ff into pyxem:master Nov 30, 2020
@hakonanes hakonanes deleted the fix-reading-lambert-projection branch November 30, 2020 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant