Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support reading EBSD patterns from Bruker h5ebsd file with ROI #339

Merged
merged 2 commits into from
Apr 21, 2021

Conversation

hakonanes
Copy link
Member

@hakonanes hakonanes commented Apr 21, 2021

Signed-off-by: Håkon Wiik Ånes hwaanes@gmail.com

Description of the change

  • Support reading EBSD patterns from a Bruker h5ebsd (HDF5) file with a region of interest (ROI)
  • Reduce test file size of the Bruker h5ebsd file, and also add two other test files (still a total file size reduction)

Thanks to @Fred-Ad for reporting this (and other) issues in #329, and also providing a dataset to test this on. Much appreciated!

Progress of the PR

For reviewers

  • The PR title is short, concise, and will make sense 1 year later.
  • New functions are imported in corresponding __init__.py.
  • New features, API changes, and deprecations are mentioned in the
    unreleased section in doc/changelog.rst.

Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
@hakonanes hakonanes added the bug Something isn't working label Apr 21, 2021
@hakonanes hakonanes added this to the v0.3.3 milestone Apr 21, 2021
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
@hakonanes
Copy link
Member Author

Will merge after checks pass.

@hakonanes hakonanes merged commit 8a853cb into pyxem:master Apr 21, 2021
@hakonanes hakonanes deleted the fix-bruker-hdf5-reader branch April 21, 2021 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant