Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add convenience method to extract grid of EBSD patterns from signal #585

Merged
merged 9 commits into from
Jan 4, 2023

Conversation

hakonanes
Copy link
Member

@hakonanes hakonanes commented Jan 3, 2023

Description of the change

This PR adds two functions:

  • EBSD.extract_grid((5, 5)) which extracts a new EBSD signal with 25 patterns evenly distributed in the original signal.
  • kikuchipy.signals.util.grid_indices((5, 5), (149, 200)) which returns 25 2D indices into a map of shape (149, 200). This is used in the above EBSD method.

Numerous other small fixes are also done.

Progress of the PR

Minimal example of the bug fix or new feature

See example added to gallery:

For reviewers

  • The PR title is short, concise, and will make sense 1 year later.
  • New functions are imported in corresponding __init__.py.
  • New features, API changes, and deprecations are mentioned in the unreleased
    section in CHANGELOG.rst.
  • New contributors are added to release.py, .zenodo.json and
    .all-contributorsrc with the table regenerated.

Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
@hakonanes hakonanes added enhancement New feature or request documentation This relates to the documentation labels Jan 3, 2023
@hakonanes hakonanes added this to the v0.8.0 milestone Jan 3, 2023
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
@hakonanes hakonanes merged commit 24abf26 into pyxem:develop Jan 4, 2023
@hakonanes hakonanes deleted the add-ebsd-extract-grid branch January 4, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This relates to the documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant