Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintain not-indexed points in refined crystal maps #632

Merged
merged 8 commits into from
Apr 7, 2023

Conversation

hakonanes
Copy link
Member

@hakonanes hakonanes commented Mar 29, 2023

Description of the change

This PR ensures not-indexed points in a crystal map are maintained after EBSD refinement (refine_orientation() and refine_orientation_projection_center()). It fixes the issue in #622, reported by @Erlendos12 (thanks).

This fix changes the API of the above mentioned refinement methods in that not-indexed points are kept as not-indexed, instead of not being part of the data (False in CrystalMap.is_in_data) as is the case in the current release. I consider the current behavior as a bug, and will therefore release this change as a patch.

I re-ran and saved tutorials with stored cell outputs affected by this change.

This fix will constitute a new 0.8.4 patch release, released after this PR is merged. I hope to do this before April 5th.

Progress of the PR

For reviewers

  • The PR title is short, concise, and will make sense 1 year later.
  • New functions are imported in corresponding __init__.py.
  • New features, API changes, and deprecations are mentioned in the unreleased
    section in CHANGELOG.rst.
  • New contributors are added to release.py, .zenodo.json and
    .all-contributorsrc with the table regenerated.

Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
@hakonanes hakonanes added bug Something isn't working documentation This relates to the documentation labels Mar 29, 2023
@hakonanes hakonanes added this to the v0.8.4 milestone Mar 29, 2023
@hakonanes hakonanes marked this pull request as draft March 29, 2023 08:15
@hakonanes hakonanes linked an issue Mar 29, 2023 that may be closed by this pull request
@Erlendos12
Copy link
Contributor

Erlendos12 commented Mar 29, 2023

Great! This will eliminate having to create masks to remove not_indexed orientations when refining. 👍

Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
@hakonanes hakonanes marked this pull request as ready for review April 7, 2023 10:44
@hakonanes
Copy link
Member Author

This should be done and merged soon, so that 0.8.4 is released later today.

Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
@hakonanes hakonanes merged commit 49e6814 into pyxem:main Apr 7, 2023
@hakonanes hakonanes deleted the fix-622 branch April 7, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation This relates to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keeping not_indexed dummy phase after orientation refinement
2 participants