-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CrystalMap.plot(), use matplotlib-scalebar, add xmap notebook #185
Conversation
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Note that most of the added lines (about 1,600) are from the notebook. |
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
This is ready for review (the notebook can be viewed here: https://orix--185.org.readthedocs.build/en/185/crystal_map.html). There is no rush, but I would like for it to be part of v0.6. |
This looks good at a glance, I'll add it to the chunk of stuff I do when I get back to #175, will easily make it into v0.6 |
The notebook has changed very little from the one in orix-demos (nbviewer link), apart from way simpler plotting. The most valuable feedback for me (although all feedback is appreciated!) would be on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm looking forward to putting this code through it's paces
Awesome, thanks a lot! Looking forward to using it myself, as it makes life much easier... |
Signed-off-by: Håkon Wiik Ånes hwaanes@gmail.com
Description of the change
This PR aims to make plotting a CrystalMap simpler.
orix.projections.CrystalMapPlot
, similar toVector3d.plot()
andMiller.plot()
)scalebar
andcolorbar
toCrystalMapPlot
for easy access, which areNone
untiladd_scalebar()
andadd_colorbar()
, respectively, are called.Progress of the PR
Minimal example of the bug fix or new feature
This code
produces this phase plot with dot product values in overlay
For reviewers
__init__.py
.unreleased section in
CHANGELOG.rst
.