Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flexible Dependency Management #97

Closed
lazyoracle opened this issue May 26, 2021 · 0 comments · Fixed by #95
Closed

Flexible Dependency Management #97

lazyoracle opened this issue May 26, 2021 · 0 comments · Fixed by #95
Assignees
Labels
dependencies Pull requests that update a dependency file
Milestone

Comments

@lazyoracle
Copy link
Member

Is your feature request related to a problem? Please describe.
Currently our dependencies involve version pinning eg,

c3/setup.py

Lines 37 to 47 in 6e7e7a0

install_requires=[
"adaptive==0.11.1",
"cma==3.0.3",
"gast==0.3.3",
"hjson==3.0.2",
"rich==9.2.0",
"numpy==1.19.5",
"scipy==1.5.2",
"tensorflow==2.4.1",
"tensorflow-estimator==2.4.0",
"tensorflow-probability==0.12.1",

The problem is that this will sooner or later lead to conflicts and issues when c3-toolset exists in environments with other packages that have even slightly differing requirements.

Describe the solution you'd like

  1. We should probably move to a more flexible >= style requirements. OR
  2. We release pre-built docker images to run everything in containers only
@lazyoracle lazyoracle added the dependencies Pull requests that update a dependency file label May 26, 2021
@lazyoracle lazyoracle added this to the 1.3 milestone May 26, 2021
@lazyoracle lazyoracle self-assigned this May 26, 2021
@lazyoracle lazyoracle linked a pull request May 26, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant