Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed processing of model config file. #103

Merged
merged 8 commits into from
Jun 9, 2021

Conversation

nwittler
Copy link
Collaborator

Bug
Instantiating models from configs did not perform some required checks performed when creating the model interactively.

Fix
Both use cases now go through the same checks.

Misc
This also required to update some test configs to avoid duplicate names.

@codecov
Copy link

codecov bot commented May 28, 2021

Codecov Report

Merging #103 (5ff764c) into dev (b6dd98f) will increase coverage by 0.07%.
The diff coverage is 86.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #103      +/-   ##
==========================================
+ Coverage   57.32%   57.39%   +0.07%     
==========================================
  Files          35       35              
  Lines        5279     5300      +21     
==========================================
+ Hits         3026     3042      +16     
- Misses       2253     2258       +5     
Impacted Files Coverage Δ
c3/model.py 73.17% <86.36%> (+0.82%) ⬆️
c3/libraries/chip.py 45.41% <0.00%> (-0.20%) ⬇️
c3/optimizers/c1.py 73.73% <0.00%> (+1.01%) ⬆️
c3/libraries/algorithms.py 19.23% <0.00%> (+1.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6dd98f...5ff764c. Read the comment docs.

@lazyoracle lazyoracle added this to the 1.3 milestone May 28, 2021
@lazyoracle lazyoracle added the bug Something isn't working label May 28, 2021
lazyoracle
lazyoracle previously approved these changes May 28, 2021
Copy link
Member

@lazyoracle lazyoracle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not waiting for the codeclimate analysis since that seems to have run into errors. Everything else looks good!

@nwittler
Copy link
Collaborator Author

nwittler commented Jun 2, 2021

Did a tiny bit to reduce complexity in c/model.py. Since a rework is in order for the model and propagation libraries in #99, this is postponed.

Copy link
Collaborator

@fedroy fedroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging approved, however we could use the codecov warnings to add tests in a timely manner

f"Tried to connect {comp.name}"
f" to non-existent device {self.subsystems[connect].name}."
)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these codecov warning are useful for adding specific tests

@nwittler nwittler merged commit 048e5fd into q-optimize:dev Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants