Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP. Migrate the plugins to become => Dynamic plugin #82

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

cmoulliard
Copy link
Collaborator

Signed-off-by: cmoulliard <cmoulliard@redhat.com>
…sExtensionPoint

Signed-off-by: cmoulliard <cmoulliard@redhat.com>
@cmoulliard
Copy link
Collaborator Author

cmoulliard commented Mar 27, 2024

IMPORTANT

The following problem has been fixed by packaging within the tarball the node_modules folder. See RELEASE - dynamic plugins section !!!

Issue

When the plugin/module @cmoulliard/plugin-quarkus-backend is loaded, then we got this error even if the dependency is well declared within the package.json file

dynamic-1.9.6' 
�[2m2024-03-27T16:45:53.220Z�[22m �[34mbackstage�[39m �[31merror�[39m an error occured while loading dynamic backend plugin '@cmoulliard/plugin-quarkus-backend' from 'file:///opt/app-root/src/dynamic-plugins-root/cmoulliard-plugin-quarkus-backend-0.1.2' Cannot find module 'jszip'
Require stack:
- /opt/app-root/src/dynamic-plugins-root/cmoulliard-plugin-quarkus-backend-0.1.2/dist/cjs/quickstartClone-5a6942c8.cjs.js
- /opt/app-root/src/dynamic-plugins-root/cmoulliard-plugin-quarkus-backend-0.1.2/dist/index.cjs.js
- /opt/app-root/src/packages/backend/dist/index.cjs.js �[36mcode�[39m=MODULE_NOT_FOUND �[36mrequireStack�[39m=/opt/app-root/src/dynamic-plugins-root/cmoulliard-plugin-quarkus-backend-0.1.2/dist/cjs/quickstartClone-5a6942c8.cjs.js,/opt/app-root/src/dynamic-plugins-root/cmoulliard-plugin-quarkus-backend-0.1.2/dist/index.cjs.js,/opt/app-root/src/packages/backend/dist/index.cjs.js �[36mstack�[39m=Error: Cannot find module 'jszip'
Require stack:
- /opt/app-root/src/dynamic-plugins-root/cmoulliard-plugin-quarkus-backend-0.1.2/dist/cjs/quickstartClone-5a6942c8.cjs.js
- /opt/app-root/src/dynamic-plugins-root/cmoulliard-plugin-quarkus-backend-0.1.2/dist/index.cjs.js
- /opt/app-root/src/packages/backend/dist/index.cjs.js
    at Module._resolveFilename (node:internal/modules/cjs/loader:1134:15)
    at ModuleObject._resolveFilename (/opt/app-root/src/packages/backend/dist/index.cjs.js:143:16)
    at Module._load (node:internal/modules/cjs/loader:975:27)
    at Module.require (node:internal/modules/cjs/loader:1225:19)
    at require (node:internal/modules/helpers:177:18)
    at Object.<anonymous> (/opt/app-root/src/dynamic-plugins-root/cmoulliard-plugin-quarkus-backend-0.1.2/dist/cjs/quickstartClone-5a6942c8.cjs.js:8:13)
    at Module._compile (node:internal/modules/cjs/loader:1356:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1414:10)
    at Module.load (node:internal/modules/cjs/loader:1197:32)
    at Module._load (node:internal/modules/cjs/loader:1013:12)
    at Module.require (node:internal/modules/cjs/loader:1225:19)
    at require (node:internal/modules/helpers:177:18)
    at Object.<anonymous> (/opt/app-root/src/dynamic-plugins-root/cmoulliard-plugin-quarkus-backend-0.1.2/dist/index.cjs.js:5:23)
    at Module._compile (node:internal/modules/cjs/loader:1356:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1414:10)
    at Module.load (node:internal/modules/cjs/loader:1197:32)

Signed-off-by: cmoulliard <cmoulliard@redhat.com>
Signed-off-by: cmoulliard <cmoulliard@redhat.com>
…dynamic

Signed-off-by: cmoulliard <cmoulliard@redhat.com>
Signed-off-by: cmoulliard <cmoulliard@redhat.com>
Signed-off-by: cmoulliard <cmoulliard@redhat.com>
Signed-off-by: cmoulliard <cmoulliard@redhat.com>
Signed-off-by: cmoulliard <cmoulliard@redhat.com>
@cmoulliard
Copy link
Collaborator Author

That are still 2 issues to be fixed by Janus engineers to fully play with our dynamic plugins as currently :

  • We cannot add our console as quarkus tab is not yet registered here. Issue 1147.
  • ScaffoldFieldExtensions is not yet supported part of the dynamic config: Issue 1146.

…nstead of cmoulliard

Signed-off-by: cmoulliard <cmoulliard@redhat.com>
Signed-off-by: cmoulliard <cmoulliard@redhat.com>
Signed-off-by: cmoulliard <cmoulliard@redhat.com>
Signed-off-by: cmoulliard <cmoulliard@redhat.com>
Signed-off-by: cmoulliard <cmoulliard@redhat.com>
Signed-off-by: cmoulliard <cmoulliard@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant