Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth/eip721: fix data type bug for bytes, fix #251 #252

Merged
merged 2 commits into from
Nov 6, 2023
Merged

eth/eip721: fix data type bug for bytes, fix #251 #252

merged 2 commits into from
Nov 6, 2023

Conversation

q9f
Copy link
Owner

@q9f q9f commented Nov 6, 2023

closes #251

@q9f q9f added the bug Something isn't working label Nov 6, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2023

Codecov Report

Merging #252 (cb7575d) into main (4e6dec8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##             main     #252   +/-   ##
=======================================
  Coverage   99.70%   99.70%           
=======================================
  Files          77       77           
  Lines        4460     4477   +17     
=======================================
+ Hits         4447     4464   +17     
  Misses         13       13           
Files Coverage Δ
lib/eth/eip712.rb 100.00% <100.00%> (ø)
spec/eth/eip712_spec.rb 100.00% <100.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@q9f q9f merged commit a527415 into main Nov 6, 2023
9 of 10 checks passed
@q9f q9f deleted the q9f/eip721 branch November 6, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Signature Mismatch Issue with bytes
2 participants