Simple way to make sure the old name remains known until user intervention

[o-jasper]

Name changes set the alias aswel if the alias is empty. Otherwise, it just sets the name.

Both alias and name are shown, if they differ. alias | name and name if they're the same.

Simply by doing strings that way, presumably you want two labels next to each other in that case?

Perhaps we might also want to know why the alias is what it is. If there is an alias and a name due to name change, there could be an "accept name".

Basically it is the idea of #1195, goal is merely to ensure that whenever the name changes, you can see the alias or the older name, so that you can piece it together manually. Keeping histories like #1189 and #659 are relevant, but this isnt intended to take it that far.

[zetok]

There is a small problem with window title bar not being correctly updated on alias change: https://d.maxfile.ro/pzpysctaql.webm

[o-jasper]

Yeah, and another issue; in changing the alias you edit both alias and name, that might be confusing to users..

[agilob]

hi @o-jasper , sorry for very long response. I just tried to checkout your branch and test it, but I run into a very wired problem:

➜  qTox git:(master) git pull o-jasper 
From github.com:tux3/qTox
 * [new branch]      copyright  -> o-jasper/copyright
 * [new branch]      master     -> o-jasper/master
 * [new branch]      newav      -> o-jasper/newav
 * [new branch]      testing    -> o-jasper/testing
You asked to pull from the remote 'o-jasper', but did not specify
a branch. Because this is not the default configured remote
for your current branch, you must specify a branch on the command line.
➜  qTox git:(master) git checkout o-jasper
➜  qTox git:(master) git pull o-jasper name_control
fatal: Couldn't find remote ref name_control

[o-jasper]

I have no idea... Just use the basics of git to be honest. I just made a branch and some edits in it, and pushed it to my fork, which PR-ed here..

Looks like i can get it via; git clone https://github.com/o-jasper/qTox/; git pull origin name_control

git clone https://github.com/tux3/qTox/;git remote add fork https://github.com/o-jasper/qTox/;git pull fork name_control merged it for me too, just asks me for commit message for it.

Just dont know enough about git to figure what the issue might me :/

[zetok]

@agilob why not use

git fetch tux3 pull/2225/head:pr2225

which just works?

[tux3]

This needs a couple of fixes before it can be merged (style problems, some bugs), so I'm going to pull it into a local branch for now and hopefully get it in shape and merged soon. See https://github.com/tux3/qTox/tree/name_control.

@o-jasper Thanks for contributing!

[zetok]

From what I remember - IMHO that shouldn't be merged at all.

It's a workaround at best, and putting workarounds in place makes people get used to them, so that when workaround is replaced by a proper solution, there are lots of people dissatisfied because there are changes that break their workflow.

[ProMcTagonist]

Why can't we just show them both separated with a fontstyle difference

[agilob]

@tux3 bump?

[LuccoJ]

I am... not entirely sure if this is the same thing I'm thinking about, but I think there's a potential social engineering issue in most Tox clients, in that you can change your alias and avatar, and if you know the alias and avatar for someone else in your friend's contact list, you can convincingly pretend to be them, without anything really to alert the victim.

Other IM systems have user-parsable addresses of some sort, so this is less of an issue, but Tox IDs are not really memorable or, for that matter, even shown to users.

[ProMcTagonist]

name history, other issues

as well as chat history for avoiding impersonation SE

[zetok]

@LuccoJ

Other IM systems have user-parsable addresses of some sort, so this is less of an issue, but Tox IDs are not really memorable or, for that matter, even shown to users.

Err, users can view them.

[agilob]

but not remember.

[ghost]

history
name history

No history = no security. I wouldn't rely on this.

Setting an alias is not something I'd expect from Average Joe.

Identicons (#711) may help. The right-click menu of a contact could display the identicon, next to Show details for example. This isn't ideal either because the identity verification is hidden, but is more reliable.

[zetok]

PR consists only of a workaround to the problem, not an actual solution. In addition, mentioned problems haven't been fixed, thus closing.