Updates of namespaces and composer.json #8
Conversation
evangelion1204
commented
Aug 16, 2014
evangelion1204
commented
- updated used namespaces
- moved example from test to example folder
- introduced composer.example.json
| "homepage": "https://github.com/qa-tools/behat-extension", | ||
| "license": "BSD-3-Clause", | ||
| "require": { | ||
| "php": ">=5.3.1", | ||
| "behat/mink-extension": "*", | ||
| "behat/mink-extension": "dev-master", |
There was a problem hiding this comment.
The dev-master means always use what's in master branch. The *@dev on the other hand means use latest stable dev version or use stable version where composer.json minimum stability is set to stable.
So the *@dev is better. Better yet you can specify ~1.3@dev,~2.0@dev (the 1.3 would allow the Behat 2.x to be used and the 2.0 would allow Behat 3.x to be used, theoretically). This way we won't force people to use Behat 3.x if they don't want.
There was a problem hiding this comment.
Currently we need to go for Behat 3.x, if we really need 2.x support we need to create a separate branch for it.
Maybe |
With #9 everything would be moved to a separate project and we would have a clean setup. This example file is currently required to run the example. |
|
Ok, corrected everything. Also moved the example composer file to the example dir. |
| @@ -25,7 +21,8 @@ | |||
| }, | |||
| "autoload-dev": { | |||
| "psr-0": { | |||
| "QATools\\behat": "tests/" | |||
| "tests\\QATools\\BehatExtension": "tests/", | |||
| "example": "" | |||
There was a problem hiding this comment.
Isn't the stuff from example namespace be loaded in that example folder and it's composer.json.dst?
There was a problem hiding this comment.
Please proceed with a changes, that are needed here.
I guess what you did forget to do is |
|
My fault, really did not push everything. I will just use localhost as url, this is probably better, cause people don't need to modifiy their hosts to get it running. |
| "mindplay/annotations": "@dev", | ||
| "behat/mink": "dev-master", | ||
| "behat/mink-selenium2-driver": "dev-master" | ||
| }, |
There was a problem hiding this comment.
Look on whole require statement.
I recommend putting as close to reality versions here as possible:
- "qa-tools/qa-tools": "~1.0@dev",
- "qa-tools/behat-extension": "~1.0@dev",
- "mindplay/annotations": "~1.2@dev",
- "behat/mink": "~1.5@dev",
- "behat/mink-selenium2-driver": "~1.1@dev"
* updated used namespaces * moved example from test to example folder * introduced composer.example.json
|
Ok updated the dependencies for the example and removed old autoload namespace. |
Updates of namespaces and composer.json
|
Merged. Thanks, @evangelion1204 . |
