-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename package for JUnit Jupiter support #2
Comments
I think I'm still a bit confused about the exact nature of their relationship. The docs say:
Which makes me think of Jupiter as some kind of reference implementation. Which makes them live together side by side and if one has new version - its partner has new version as well. If that's a valid way of thinking about them, maybe it's not that big of a deal. In case JUnit6 is out with its new reference implementation, I'd then create another package - junit6. |
It's not. 😉 Jupiter is not a reference implementation: it is the new programming and extension model introduced in JUnit 5. In stark contrast to previous versions of JUnit, with JUnit 5, "JUnit 5" becomes an umbrella project for the other three projects: Platform, Jupiter, and Vintage. That means that JUnit Jupiter (as a programming model) may very likely exist in JUnit 6, JUnit 7, etc. -- but without changes to packages on JUnit's side. In other words, if JUnit 6 is released with continued support for JUnit Jupiter, your current package name will be confusing to users... since they would be required to use classes from your Make sense? It's of course up to you how you name your packages; I'm just suggesting to you what we (the JUnit Team) suggest to everyone. FWIW, I have followed my own advice for Spring 5's testing support with a package named Regards, Sam |
For further background on the impetus for the "JUnit Jupiter" naming, please see this issue: junit-team/junit5#286. |
This is a breaking change, but prev release happened just recently, so hopefully people haven't started to use it actively and they won't be upset.
Ok, thanks for the help! |
You're welcome! |
Since your support for JUnit 5 is actually support for the JUnit Jupiter programming model, I highly recommend that you rename the
io.qala.datagen.junit5
package toio.qala.datagen.junit.jupiter
in order to avoid conflicts with future versions of JUnit (e.g., JUnit 6's support for JUnit Jupiter).The text was updated successfully, but these errors were encountered: