Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added _I type {string} chars to {string}_ to send find-grained events #124

Merged
merged 3 commits into from
Dec 21, 2023
Merged

added _I type {string} chars to {string}_ to send find-grained events #124

merged 3 commits into from
Dec 21, 2023

Conversation

AlexGalichenko
Copy link
Contributor

@AlexGalichenko AlexGalichenko commented Dec 21, 2023 •
edited
Loading

  • Updated the CHANGELOG.md.
  • Checked that there aren't other open pull requests for the same issue/update.
  • Checked that your contribution follows the project's contribution guidelines.
  • Added corresponding unit/E2E tests
  • Unit and E2E pass

Description

added I type {string} chars to {string} to send find-grained events

@AlexGalichenko AlexGalichenko added the enhancement New feature or request label Dec 21, 2023
@AlexGalichenko AlexGalichenko self-assigned this Dec 21, 2023
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 21, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

4 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

ALegchilov
ALegchilov reviewed Dec 21, 2023
View reviewed changes
test-e2e/features/memory.feature
@@ -26,7 +26,7 @@ Feature: memory
Scenario: page title
Then I save page title as 'memory'
Then I expect '$memory' memory value to be equal '@qavajs'

Copy link
Contributor

@ALegchilov ALegchilov Dec 21, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧐

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:/

@AlexGalichenko AlexGalichenko merged commit b7e5458 into main Dec 21, 2023
4 checks passed
@AlexGalichenko AlexGalichenko deleted the type-chars branch December 21, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ALegchilov ALegchilov ALegchilov approved these changes

@KirillBogdanets KirillBogdanets KirillBogdanets approved these changes

@nomid0612 nomid0612 Awaiting requested review from nomid0612

Assignees

@AlexGalichenko AlexGalichenko

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexGalichenko @KirillBogdanets @ALegchilov