Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support filling images in cells #1923

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Support filling images in cells #1923

merged 2 commits into from
Jun 19, 2024

Conversation

wangsongyan
Copy link
Contributor

PR Details

Support filling images in cells

Description

Add Fill option in excelize.GraphicOptions to allow user filling images in cells.

Related Issue

Motivation and Context

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@xuri xuri added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 17, 2024
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.30%. Comparing base (c349313) to head (4190a78).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1923      +/-   ##
==========================================
- Coverage   99.30%   99.30%   -0.01%     
==========================================
  Files          32       32              
  Lines       24989    24962      -27     
==========================================
- Hits        24815    24788      -27     
  Misses         93       93              
  Partials       81       81              
Flag Coverage Δ
unittests 99.30% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@xuri xuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your pull request. This library already supports adding images to auto-fits the cell size by the AutoFit field, but keeps the aspect ratio of the image. I have made the following changes based on your branch:

  • The name "Fill" was the same as the Fill data type, renaming it to AutoFitIgnoreAspect will be more clear and meaningful
  • Added documentation for how to use the AutoFitIgnoreAspect fields
  • Simplify code for override width and height by AutoFitIgnoreAspect value
  • Update the unit tests for it

@xuri xuri merged commit f04aa8d into qax-os:master Jun 19, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
No open projects
Status: Features
Development

Successfully merging this pull request may close these issues.

2 participants