#195: proposed resolution to the issue

[rafaelmiti]

PR Details

This PR fix the issue #195.

Description

It checks if there's N (defined by the user) empty lines in sequence in the sheet, and if so, it stops the GetRows function. I also had a more than 1 million empty lines sheet.

How Has This Been Tested

It was created a unit test that covers all code created. The overall coverage of the project still roughly the same, and it's all passing.

It was also made many api tests in an in house project, with different files. A simple file created by hand with few rows, and with a large file (~40k rows) from a real client.

Types of changes

• Docs change / refactoring / dependency upgrade
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[codecov-io]

Codecov Report

Merging #319 into master will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #319      +/-   ##
==========================================
+ Coverage   98.84%   98.89%   +0.04%     
==========================================
  Files          18       18              
  Lines        3990     3989       -1     
==========================================
+ Hits         3944     3945       +1     
+ Misses         27       26       -1     
+ Partials       19       18       -1

Impacted Files	Coverage Δ
excelize.go	95.51% <ø> (ø)	⬆️
lib.go	97.97% <ø> (ø)	⬆️
picture.go	99.28% <ø> (ø)	⬆️
styles.go	100% <ø> (ø)	⬆️
file.go	89.65% <ø> (ø)	⬆️
chart.go	99.3% <ø> (ø)	⬆️
table.go	99.14% <ø> (ø)	⬆️
sheet.go	97.65% <ø> (ø)	⬆️
cell.go	98.19% <ø> (ø)	⬆️
datavalidation.go	100% <ø> (ø)	⬆️
... and 8 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a6f66a...509dc47. Read the comment docs.

[xuri]

Hi @rafaelmiti, thanks for your pull request. I have made some change base on yours commit. The function GetRows() will return the number of valid rows now.