Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the kegg_blacklist bug (kegg_blacklist.txt pathways would not … #108

Merged
merged 4 commits into from
Feb 22, 2022

Conversation

WackerO
Copy link
Collaborator

@WackerO WackerO commented Feb 21, 2022

Many thanks to contributing to qbic-pipelines!

Fixed the kegg_blacklist bug (kegg_blacklist.txt pathways would not be added to blacklist), removed report_options.yml from usage and schema, changed the skip_pathway_analysis parameter to not skip by default

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

…be added to blacklist), removed report_options.yml from usage and schema, changed the skip_pathway_analysis parameter to not skip by default
@WackerO
Copy link
Collaborator Author

WackerO commented Feb 21, 2022

I am not sure how to make the pipeline call certain pathways, so I could not actually check if the blacklisting itself works (i.e. if pathways on the blacklist are skipped during analysis); I only verified that the pathways from the blacklist.txt file are added to the blacklist during computation.

Copy link
Collaborator

@ggabernet ggabernet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @WackerO ,

I had just a minor comment, and also the changelog should be updated.

Otherwise looking good!

modules/local/report.nf Outdated Show resolved Hide resolved
Copy link
Collaborator

@ggabernet ggabernet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@WackerO WackerO merged commit ecd123a into qbic-pipelines:dev Feb 22, 2022
@WackerO WackerO deleted the deseq_blacklist branch February 24, 2022 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants