Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Template update #115

Merged
merged 15 commits into from
Apr 29, 2022
Merged

Template update #115

merged 15 commits into from
Apr 29, 2022

Conversation

WackerO
Copy link
Collaborator

@WackerO WackerO commented Mar 31, 2022

Many thanks to contributing to qbic-pipelines!

Please fill in the appropriate checklist below (delete whatever is not relevant). These are the most common things requested on pull requests (PRs).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/qbic-pipelines/rnadeseq/tree/master/.github/CONTRIBUTING.md

ggabernet
ggabernet reviewed Mar 31, 2022
View reviewed changes
Copy link
Collaborator

@ggabernet ggabernet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @WackerO , I had some comments and corrections here, but otherwise looks good!

.github/markdownlint.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
assets/email_template.html Outdated Show resolved Hide resolved
assets/email_template.html Outdated Show resolved Hide resolved
assets/email_template.html Outdated Show resolved Hide resolved
assets/multiqc_config.yml Outdated Show resolved Hide resolved
assets/multiqc_config.yml Outdated Show resolved Hide resolved
conf/base.config Outdated Show resolved Hide resolved
docs/usage.md Outdated Show resolved Hide resolved
WackerO and others added 8 commits March 31, 2022 14:54
@WackerO @ggabernet
Update assets/email_template.html
df8d05a 
Co-authored-by: Gisela Gabernet <gisela.gabernet@gmail.com>
@WackerO @ggabernet
Update assets/email_template.html
2f179e1 
Co-authored-by: Gisela Gabernet <gisela.gabernet@gmail.com>
@WackerO @ggabernet
Update assets/email_template.html
99dd38b 
Co-authored-by: Gisela Gabernet <gisela.gabernet@gmail.com>
@WackerO @ggabernet
Update assets/multiqc_config.yml
9f096de 
Co-authored-by: Gisela Gabernet <gisela.gabernet@gmail.com>
@WackerO @ggabernet
Update assets/multiqc_config.yml
ad9cfc5 
Co-authored-by: Gisela Gabernet <gisela.gabernet@gmail.com>
@WackerO @ggabernet
Update conf/base.config
c395fe8 
Co-authored-by: Gisela Gabernet <gisela.gabernet@gmail.com>
@WackerO
Fixed formatting, undid ci.yml changes
456345c
@WackerO
Ran prettier
ae82d8f
ggabernet
ggabernet approved these changes Mar 31, 2022
View reviewed changes
Copy link
Collaborator

@ggabernet ggabernet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @WackerO , just the Editorconfig linting is failing now, so that would need to be fixed, but I'll approve the PR already!

@WackerO WackerO changed the title Dev Template update Apr 21, 2022
@WackerO WackerO merged commit 57fc7ac into qbic-pipelines:dev Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggabernet ggabernet ggabernet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WackerO @ggabernet