more networking natives #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs a qbicc release with qbicc/qbicc#1672 |
dgrove-oss
added
the
needs qbicc release ⌛
dmlloyd
approved these changes
Jan 20, 2023
|
Added two more since you reviewed it; this is the last handful we needed for a trivial request to go through. |
dmlloyd
reviewed
Jan 23, 2023
dmlloyd
approved these changes
Jan 23, 2023
|
I extracted qbicc/qbicc#1675. As I stripped out irrelevant code, it actually got into a pretty small test case, that did not actually involve the pointers being taken (just the conditional update of the size of the variable whose address is being conditionally taken). |
dmlloyd
approved these changes
Jan 23, 2023
dgrove-oss
force-pushed
the
more-natives
branch
from
721af9d
to
1791f5a
Compare
dgrove-oss
removed
the
needs qbicc release ⌛
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be enough to get us out of the core JDK when accepting a socket connection and back up into netty/vert.x code