fix typos

README.md

@@ -37,7 +37,10 @@ Example:
 ```bash
 java -jar postman.jar list -u <user> <sample> @path/to/config.txt 
 ```
-The structure of the configuration file is:       <code>[-cliOption] [value]</code>   
+The structure of the configuration file is:
+```text
+[-cliOption] [value]
+```
 For example: To set the ApplicationServerURL to another URL we have to use: <code>-as [URL]</code>
 
 To use our openBIS URL we write the following lines in the config file:  

src/main/java/life/qbic/qpostman/common/ProgressBar.java

@@ -97,12 +97,8 @@ private String buildProgressBar() {
     dateFormat.setTimeZone(TimeZone.getTimeZone("UTC"));
     String remainingTime = dateFormat.format(new Date(remainingDownloadTime));
 
-    for (int i = 0; i < numberProgressStrings; i++) {
-      progressBar.append("#");
-    }
-    for (int i = numberProgressStrings; i < BARSIZE; i++) {
-      progressBar.append(" ");
-    }
+    progressBar.append("#".repeat(Math.max(0, numberProgressStrings)));
+    progressBar.append(" ".repeat(Math.max(0, BARSIZE - numberProgressStrings)));
 
     progressBar.append("]\t");
     FileSize downloadedSize = FileSize.of(this.downloadedSize);

src/main/java/life/qbic/qpostman/common/functions/SearchFiles.java

@@ -2,7 +2,6 @@
 
 import static java.util.Objects.requireNonNull;
 
-import ch.ethz.sis.openbis.generic.asapi.v3.IApplicationServerApi;
 import ch.ethz.sis.openbis.generic.asapi.v3.dto.dataset.id.DataSetPermId;
 import ch.ethz.sis.openbis.generic.dssapi.v3.IDataStoreServerApi;
 import ch.ethz.sis.openbis.generic.dssapi.v3.dto.datasetfile.DataSetFile;
@@ -24,7 +23,7 @@ public class SearchFiles implements Function<Collection<DataSetWrapper>, Collect
 
     private final Collection<IDataStoreServerApi> dataStoreServerApis;
 
-    public SearchFiles(IApplicationServerApi applicationServerApi, Collection<IDataStoreServerApi> dataStoreServerApis) {
+    public SearchFiles(Collection<IDataStoreServerApi> dataStoreServerApis) {
         this.dataStoreServerApis = dataStoreServerApis;
     }
 

src/main/java/life/qbic/qpostman/download/DownloadCommand.java

@@ -65,7 +65,7 @@ public void run() {
             log.info(
                 "Downloading %s files (%s)".formatted(sortedFiles.size(), FileSizeFormatter.format(
                     FileSize.of(sortedFiles.stream().mapToLong(file -> file.fileSize().bytes()
-                    ).sum())), 6));
+                    ).sum()), 6)));
             int counter = 0;
             List<DownloadReport> downloadReports = sortedFiles.stream()
                 .map(functions.writeFileToDisk())
@@ -106,7 +106,7 @@ private Functions functions() {
         OpenBisSessionProvider.init(applicationServerApi, authenticationOptions.user, new String(authenticationOptions.getPassword()));
         SearchDataSets searchDataSets = new SearchDataSets(applicationServerApi);
         Collection<IDataStoreServerApi> dataStoreServerApis = ServerFactory.dataStoreServers(serverOptions.dss_urls, serverOptions.timeoutInMillis);
-        SearchFiles searchFiles = new SearchFiles(applicationServerApi, dataStoreServerApis);
+        SearchFiles searchFiles = new SearchFiles(dataStoreServerApis);
         FileFilter myAwesomeFileFilter = FileFilter.create().withSuffixes(filterOptions.suffixes);
         WriteFileToDisk writeFileToDisk = new WriteFileToDisk(dataStoreServerApis.toArray(IDataStoreServerApi[]::new)[0],
             downloadOptions.bufferSize, Path.of(downloadOptions.outputPath), downloadOptions.successiveDownloadAttempts);

src/main/java/life/qbic/qpostman/download/WriteFileToDisk.java

@@ -95,7 +95,7 @@ public DownloadReport apply(DataFile dataFile) {
         return downloadReport;
     }
 
-    record DownloadReport(long expectedCrc32, long actualCrc32, Path outputPath) {
+    public record DownloadReport(long expectedCrc32, long actualCrc32, Path outputPath) {
         public boolean isSuccess() {
             return expectedCrc32 == actualCrc32;
         }

src/main/java/life/qbic/qpostman/download/WriteUtils.java

@@ -67,7 +67,7 @@ private static Optional<Long> readCrc32FromFile(Path file) {
       return Optional.empty();
     }
 
-    try (BufferedReader reader = Files.newBufferedReader(crc32FileName);) {
+    try (BufferedReader reader = Files.newBufferedReader(crc32FileName)) {
       String firstLine = reader.readLine();
       return Optional.ofNullable(firstLine)
           .map(line -> Long.parseLong(line.split("\\s+")[0], 16));

src/main/java/life/qbic/qpostman/list/ListCommand.java

@@ -96,7 +96,7 @@ private Functions setupFunctions() {
         SearchDataSets searchDataSets = new SearchDataSets(applicationServerApi);
         FileFilter myAwesomeFileFilter = FileFilter.create()
             .withSuffixes(filterOptions.suffixes);
-        SearchFiles searchFiles = new SearchFiles(applicationServerApi, dataStoreServerApis);
+        SearchFiles searchFiles = new SearchFiles(dataStoreServerApis);
         FindSourceSample findSourceSample = new FindSourceSample(serverOptions.sourceSampleType);
         DataFileFormatter dataFileFormatter = new DataFileFormatter(listOptions.exactFilesize);
         SortFiles sortFiles = new SortFiles();

src/test/groovy/FailingSpockTest.groovy

@@ -1,5 +1,5 @@
 import spock.lang.Ignore
-import spock.lang.Specification;
+import spock.lang.Specification
 
 /**
  * Use this test to see whether maven executes Spock tests or not.
@@ -8,6 +8,6 @@ import spock.lang.Specification;
 class FailingSpockTest extends Specification {
     def "this test always fails"() {
       expect:
-      1 == 2;
+      1 == 2
     }
 }