Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wishlist] Dark Theme #6434

Open
SicariusNoctis opened this issue Feb 27, 2017 · 97 comments

Comments

Projects
None yet
@SicariusNoctis
Copy link

commented Feb 27, 2017

Is there a way to use Qt's theme engine to support themeing? In particular, a simple dark theme option would be great: qBittorrent is blindingly white at night when I want to watch some... legally downloaded TV shows.

P.S. I'm on Windows.


EDIT: I'm on Linux now. Dark themes galore! Join the masterrace, folks!

@smokecrack

This comment has been minimized.

Copy link

commented Mar 14, 2017

Ooh would love to see a night mode for qbittorrent. Have just lately tried night mode themes for programs and so much easier on the eyes when room is darker

@Poilaucul

This comment has been minimized.

Copy link

commented Feb 23, 2018

Definitely need a dark theme.

@Kirov123

This comment has been minimized.

Copy link

commented Mar 4, 2018

I agree, a dark mode or a dark theme with theming support would be fantastic.

@brusfest

This comment has been minimized.

Copy link

commented Mar 7, 2018

Can we get an update on where you've gotten on this? I know a lot of people really would like this feature.

@suratovvlad

This comment has been minimized.

Copy link

commented Mar 7, 2018

I haven't update My fork for a long time, however I would appreciate any help.
Also, I have installer for windows and aur repo for archlinux

@oghaki

This comment has been minimized.

Copy link

commented Mar 11, 2018

This is by far the proposed feature I care most about. I would prefer to only have a dark theme over having the extremely bright UI that is currently present.

@Garbonzo17

This comment has been minimized.

Copy link

commented Mar 11, 2018

@SicariusNoctis

This comment has been minimized.

Copy link
Author

commented Mar 11, 2018

Hey guys, could you please stop adding "me too" comments? To show your support, you can thumbs up the request. Thanks!

@realies

This comment has been minimized.

Copy link

commented Apr 2, 2018

Dark theme for the web interface would also be great.

@5ay3h 5ay3h referenced this issue Apr 5, 2018

Closed

Color and font themes #6698

12 of 12 tasks complete
@Wizek

This comment has been minimized.

Copy link

commented Apr 5, 2018

@realies Dark theme for the web interface may actually be the simplest to implement! It's just CSS after all and it's trivial to override. Doesn't even require cooperation of the maintainer(s) or new release of qBittorrent, could be using something like https://userstyles.org/.

Heck, we may even find https://chrome.google.com/webstore/detail/deluminate/iebboopaeangfpceklajfohhbpkkfiaa to be more than adequit for the task, so that only requires a single extension install and not even any code.

It's strange that I'm only now thinking of this option as I use Deluminate daily (nightly?), and was troubled by qBittorrent's bright interface for some time now. I hope to give this a try soon as this seems like our best option so far.

@realies

This comment has been minimized.

Copy link

commented Apr 5, 2018

No need for third party add-ons/scripts when it can be an option in the settings.

@Wizek

This comment has been minimized.

Copy link

commented Apr 5, 2018

@realies You are reading my comment in reverse.

Of course, if/when it will become an option in the settings then I will likely prefer to use that too.
But the maintainers don't exactly even seem to be keen on merging anyone else's work in this direction, let alone implementing something themselves. So I wouldn't hold our breath for official support any time soon.

And what I am saying could be a solution (workaround?) even in the meantime, that those of us who care about this can start using even today.

@realies

This comment has been minimized.

Copy link

commented Apr 5, 2018

Cool insight, I would wait for an official implementation.

@Wizek

This comment has been minimized.

Copy link

commented Apr 5, 2018

That's okay. How long do you think you'll have to wait? How long are you prepared to hold out? Or maybe being able to use a dark theme is not very important for you after all?

@realies

This comment has been minimized.

Copy link

commented Apr 5, 2018

It is not a necessity, but a nice to have due to aforementioned reasons.

If the developers aren't really bothered with implementing a theme system, they could also do with a simple checkbox entitled "night mode" that inserts a filter:invert(100%) class on the html tag.

@Wizek

This comment has been minimized.

Copy link

commented Apr 5, 2018

That's quite exactly what Deluminate does, except it goes a step further with color-correction:

filter: invert(100%) hue-rotate(180deg);

And it has further support for keeping images non-inverted that may or may not be important for the web ui.

@Wizek

This comment has been minimized.

Copy link

commented Apr 5, 2018

There is also this Firefox variety: https://addons.mozilla.org/en-US/firefox/addon/owl/

@GlobalSaffer

This comment has been minimized.

Copy link

commented Apr 16, 2018

Yes, please.

@Mav3r1x

This comment has been minimized.

Copy link

commented May 4, 2018

Any updates?

@DrXadium

This comment has been minimized.

Copy link

commented May 5, 2018

I would be all for just using the web interface with a new skin, but the problem is I rely on the search plugins which (I believe) are still not accessible through the web interface. If I had a way to run those searches as well, then I wouldn't care about waiting for a native dark theme to come to the program on Windows.

@pullup

This comment has been minimized.

Copy link

commented May 23, 2018

It's currently blinding me from off to the side on a side monitor. We need dark mode!

@duttaditya18

This comment has been minimized.

Copy link

commented May 24, 2018

👍 for a dark mode!

@blu3nh

This comment has been minimized.

Copy link

commented May 24, 2018

Here's to hoping that it will be implemented

@r1k0

This comment has been minimized.

Copy link

commented Mar 30, 2019

Updated fork, AUR package and installer for Windows

Can you post a screenshot of this in action please.

image

Updated fork, AUR package and installer for Windows

Hm, interesting. What is this compiled from?

Fork https://github.com/suratovvlad/qBittorrent with stylesheets from https://github.com/ColinDuquesnoy/QDarkStyleSheet

Installer contains the application that compiled with mingw-w64

thanks a lot, that makes my day night! (on arch ➜ ~ yay -S qbittorrent-dark-git)

@SicariusNoctis

This comment has been minimized.

Copy link
Author

commented Mar 31, 2019

Personally, I'm just using the Adapta-Nokto-Eta theme from adapta-gtk-theme. the QT5 theme "Breeze Dark" from KDE Plasma; on non-KDE DEs, simply install qt5ct, select your desired theme, and set the environment variable to QT_QPA_PLATFORMTHEME="qt5ct". It makes more applications than just qBittorrent dark.

(See OP for screenshot.)

@george-emerald

This comment has been minimized.

Copy link

commented Apr 2, 2019

Updated fork, AUR package and installer for Windows

Can you post a screenshot of this in action please.

image

Updated fork, AUR package and installer for Windows

Hm, interesting. What is this compiled from?

Fork https://github.com/suratovvlad/qBittorrent with stylesheets from https://github.com/ColinDuquesnoy/QDarkStyleSheet

Installer contains the application that compiled with mingw-w64

The stable windows intaller gives me an error. "Can't write maintenance service: unknown error".

@silence48

This comment has been minimized.

Copy link

commented Apr 4, 2019

Updated fork, AUR package and installer for Windows

Thank you sir! Works Great (run installer as administrator if you get an error)
Not sure why the official maintainers won't add this since it literally is a 5 minute code change, even making it work with windows themes wouldn't take more than a couple hours... regardless, thanks for the build!

qbittorrentdark

@Aida-Enna

This comment has been minimized.

Copy link

commented Apr 5, 2019

+1 for dark mode in offical fork

@nevadarain

This comment has been minimized.

Copy link

commented Apr 17, 2019

I'm so confused here. Is this dark theme for Qbittorrent for Windows or Linux? I'm using Linux Mint, if this is for Linux hiow do you get the dark theme? I saw an executable in one of the above links, so do you just run the executable to set this up in Windows(Do this install a new version of Qbit with a dark theme already integrated into it?)

Im also interested in setting this up in linux, so any help would be appreciated.

@silence48

This comment has been minimized.

Copy link

commented Apr 17, 2019

@nevadarain

This comment has been minimized.

Copy link

commented Apr 17, 2019

I didn't see a linux build but the link goes to a qbb fork that has a dark theme. You could build it for linux...

On Wed, Apr 17, 2019, 4:01 PM nevadarain @.***> wrote: I'm so confused here. Is this dark theme for Qbittorrent for Windows or Linux? I'm using Linux Mint, if this is for Linux hiow do you get the dark theme? I saw an executable in one of the above links, so do you just run the executable to set this up in Windows(Do this install a new version of Qbit with a dark theme already integrated into it?) Im also interested in setting this up in linux, so any help would be appreciated. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#6434 (comment)>, or mute the thread https://github.com/notifications/unsubscribe-auth/AIQBH5HYXVFQYLZ3KIP77QLPQ56ZZANCNFSM4DBTJJCA .

That's odd since he clearly has a dark theme in Arch Linux
#6434 (comment)

@2635599

This comment has been minimized.

Copy link

commented Apr 20, 2019

i'm running the plata theme in mint cinnamon 19.1 and it themes everything except qbittorrent. to me that's a bug in qbt.

@2635599

This comment has been minimized.

Copy link

commented Apr 25, 2019

how about answering nevadarain's last question? devs have had 8 days to answer, MORE than enough time.

@2635599

This comment has been minimized.

Copy link

commented Apr 25, 2019

Personally, I'm just using the Adapta-Nokto-Eta theme from adapta-gtk-theme. It makes more applications than just qBittorrent dark.

(See OP for screenshot.)

i've used the aptada themes and they leave a lot unthemed. the only one that themes everything except for qbt is plata. currently using plata-noir.

@SicariusNoctis

This comment has been minimized.

Copy link
Author

commented Apr 26, 2019

@2635599 I made an inaccuracy: it turns out that screenshot I posted above actually uses the theme Breeze Dark from KDE Plasma. Looks like qBittorrent, a Qt based program, is using a Qt5 theme (big surprise). If you want QT5 themes to work on a non-KDE environment, I recommend qt5ct.

On a side note, I can't see anything wrong with the GTK2/GTK3 theme adapta-nokoto-eta.

@Ansem93

This comment has been minimized.

Copy link

commented Apr 26, 2019

Hi,
I just wanted to suggest this pattern for dark themes:
https://github.com/dracula/dracula-theme/
I aleady saw it in other projects and it's great!
I will also ask to add it to the web interface since I'm using qbittorrent only from it!

@2635599

This comment has been minimized.

Copy link

commented Apr 26, 2019

Hi,
I just wanted to suggest this pattern for dark themes:
https://github.com/dracula/dracula-theme/
I aleady saw it in other projects and it's great!
I will also ask to add it to the web interface since I'm using qbittorrent only from it!

really? qbt just needs to be fixed to adopt the theme being used system wide. there is no reason this can't be done / fixed.

@suratovvlad

This comment has been minimized.

Copy link

commented May 3, 2019

@mo0nsniper @WeaponizedMeme
It is possible to do it, I really close to provide it via my fork, however I need a little bit more time to link (there is an some issue) qbittorrent with libqdark.

If you want to test it with libqdark example, you could get it here, with my libqdark library sources

Finally I managed it, and now, it is possible to change qbittorrent theme with Windows 10 setting

image

Styles has been updated by @ColinDuquesnoy, so, now it looks a little bit different

@RabidWolf

This comment has been minimized.

Copy link

commented May 3, 2019

@mo0nsniper @WeaponizedMeme
It is possible to do it, I really close to provide it via my fork, however I need a little bit more time to link (there is an some issue) qbittorrent with libqdark.
If you want to test it with libqdark example, you could get it here, with my libqdark library sources

Finally I managed it, and now, it is possible to change qbittorrent theme with Windows 10 setting

image

Styles has been updated by @ColinDuquesnoy, so, now it looks a little bit different

Great job works for me, just 1 question does this work in 4.1.5? 4.2.0 alpha works but rather use stable release.

@suratovvlad

This comment has been minimized.

Copy link

commented May 3, 2019

Great job works for me, just 1 question does this work in 4.1.5? 4.2.0 alpha works but rather use stable release.

It requires from me to update another branch based on 4.1.5 in similar way and rebuild executable, so, I don't see any restrictions.
I'm still waiting 4.1.6 or stable 4.2.0 to start supporting only stable releases for Windows

Done, updated release links
UPD. Updated installers to fix light theme

@WolfganP

This comment has been minimized.

Copy link

commented May 4, 2019

As the AltWebUI was implemented to be modified at runtime and introduce changes without the need of rebuilding the app, I wonder if there's any QT feature that allows for the them to be external and be loaded at app launch.
Articles like https://stackoverflow.com/questions/36335481/dynamically-change-qml-theme-at-runtime and http://www.webupd8.org/2015/11/configure-qt5-application-style-icons.html seems to indicate a way to do it, maybe is a possible path to develop once and let the theme to be externally supplied & customized by users without requiring devs time.
@Chocobo1 @glassez do you think that's possible? (you probably knows the QT environment in qBt better than anyone else)

@RabidWolf

This comment has been minimized.

Copy link

commented May 4, 2019

Great job works for me, just 1 question does this work in 4.1.5? 4.2.0 alpha works but rather use stable release.

It requires from me to update another branch based on 4.1.5 in similar way and rebuild executable, so, I don't see any restrictions.
I'm still waiting 4.1.6 or stable 4.2.0 to start supporting only stable releases for Windows

Done, updated release links
UPD. Updated installers to fix light theme

Thanks. Stable works with no crashes.

@silence48

This comment has been minimized.

Copy link

commented May 4, 2019

@chenzen666

This comment has been minimized.

Copy link

commented May 12, 2019

sorry for being a bit slow i have installed the windows qbittorrent_dark and i cannot see where to change to the dark theme.
any help would be appreciated as to what im doing wrong.

@suratovvlad

This comment has been minimized.

Copy link

commented May 12, 2019

sorry for being a bit slow i have installed the windows qbittorrent_dark and i cannot see where to change to the dark theme.
any help would be appreciated as to what im doing wrong.

Latest version here

image

@chenzen666

This comment has been minimized.

Copy link

commented May 12, 2019

got that one and libqdark v0.5.5 installed qbittorrent_darkv 4.1.6 where do i put libqdark folder or what do i do with it ? if anything

@chenzen666

This comment has been minimized.

Copy link

commented May 12, 2019

sorted uninstalled it and redownloaded the file then installed it and now working

@ForeverZer0

This comment has been minimized.

Copy link

commented May 20, 2019

Guessing we should just abandon all hope on this issue. Shame, really love the application, but the terrible clash of its interface with the rest of my desktop environment is unappealing. Adding this enhancement would definitely make this the undisputed champion of all clients, as it already holds that status as far as functionality goes IMHO.

@WolfganP

This comment has been minimized.

Copy link

commented May 20, 2019

@thalieht do you think a portable (outside the core code) Qt style file is doable as per my comment above? (#6434 (comment) there was no feedback to the comment)

@thalieht

This comment has been minimized.

Copy link
Contributor

commented May 20, 2019

@WolfganP i don't know about the WebUI but #9283 was supposed to do something like that for the GUI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.