added current board name to command line #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamwillzhu
commented
May 12, 2020
lib/3llo/controller.rb
Outdated
| command_buffer = Readline.readline("\e[15;48;5;27m 3llo \e[0m > ", true) | ||
| begin | ||
| board = Application.fetch_board!() | ||
| command_buffer = Readline.readline("\e[15;48;5;27m 3llo \e[0m > \e[1m\e[33m #{board.name} \e[0m > ", true) |
There was a problem hiding this comment.
I wasn't sure what \e[15;48;5;27m and \e[0m meant. After doing some research I found out that they are for colorizing the output. But when I try it on my terminal the color doesn't change at all. Is this dependent on the terminal for the output to show color?
There was a problem hiding this comment.
What's your expectation for the Readline output?
There was a problem hiding this comment.
I thought it would show colors like how the it's shown in the README GIF
There was a problem hiding this comment.
I recommend use this background color instead for easy reading.
\e[15;48;5;27m 3llo \e[0m > \e[45m 3llo \e[0m >
qcam
reviewed
May 12, 2020
fix rubocop error changed color of board name on status line and small refactor
qcam
approved these changes
May 13, 2020
|
Thank you @iamwillzhu! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Display the current board name on the command line
Related Issues
#76
Manual Testing Plan