Saxy.XML.element/3 and a non-list third argument results in a Dialyzer error

[thbar]

On a project which uses Saxy.XML, I get Dialyzer errors with this code:

element("siri:StopVisitTypes", [], "all")

The code itself works fine.

I did a bit of digging to understand why Dialyzer reports an error, here are my findings!

The Saxy.XML code does support the call I wrote above indeed, here:

saxy/lib/saxy/xml.ex

Lines 71 to 81 in 98e2c9e

	def element(name, attributes, children) when not is_nil(name) and is_list(children) do
	{
	to_string(name),
	attributes(attributes),
	children(children)
	}
	end
	def element(name, attributes, child) when not is_nil(name) do
	element(name, attributes, [child])
	end

The typespecs, on the other hand, appear to require a list:

saxy/lib/saxy/xml.ex

Lines 24 to 30 in 98e2c9e

	@type element() :: {
	name :: String.t(),
	attributes :: [{key :: String.t(), value :: String.t()}],
	children :: [content]
	}
	@type content() :: element() | characters() | cdata() | ref() | comment() | String.t()

For now I'm turning my "all" into ["all"] to fix the error, but I wonder if we could modify the typespecs in Saxy to match the allowed behaviour here?

Thanks!

[qcam]

@thbar I think it's a spec bug. It should be fixed via be744ff