Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 'tm_rho' parameter for Hasenbusch mass preconditioning for twiste… #15

Conversation

kostrzewa
Copy link

…d clover HMC using tmLQCD

@Marcogarofalo @sunpho84 After some more thought I realised that as far as I understand, we won't be able to rely on the rho parameter in the clover accessor for our purposes.

I've added a tm_rho parameter to QUDA which acts like a twisted mass in the diagonal of the asymetrically preconditioned twisted clover operator (but not in the inverse of the diagonal).

I think this doesn't break anything (unless one sets tm_rho non-zero). If it does break anything, the PR acceptance tests in the QUDA repo should uncover any breakage.

@kostrzewa
Copy link
Author

The tm_rho parameter will only work with the tmLQCD in this PR: Marcogarofalo/tmLQCD#15

@@ -342,6 +342,8 @@ void printQudaInvertParam(QudaInvertParam *param) {
P(m5, INVALID_DOUBLE);
P(Ls, INVALID_INT);
P(mu, INVALID_DOUBLE);
P(epsilon, INVALID_DOUBLE);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is unrelated but needed right?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was somehow never added. None of these are really needed, but it makes a cleaner parameter struct if it can be properly initialised with default values and the checks will catch incorrect entries where possible.

@kostrzewa
Copy link
Author

We have a problem now though, as the QUDA-MG in the generic_kernel framework is not done yet, which means that we either get the 1+1 twisted clover operator (which I based on the generic_kernel branch) or the MG, but not both right now...

tm_rho could instead also be added as an addition to the 1.1.x branch such that we can make progress on figuring out if the MG will work properly for (degenerate) twisted clover HMC.

@kostrzewa
Copy link
Author

We have a problem now though, as the QUDA-MG in the generic_kernel framework is not done yet, which means that we either get the 1+1 twisted clover operator (which I based on the generic_kernel branch) or the MG, but not both right now...

2-level MG works, however.

@Marcogarofalo Marcogarofalo merged commit 2c5ed18 into feature/ndeg-twisted-clover Aug 6, 2021
@kostrzewa kostrzewa deleted the feature/ndeg-twisted-clover_tm_rho branch August 10, 2021 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants