docs: add missing provider_ip field in examples
#466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stavros-k
commented
May 3, 2023
•
stavros-k
commented
- he.net
- selfhost.de
- servercow
- he.net - selfhost.de - servercow
qdm12
changed the title
provider_ip field in examples
|
Hi @stavros-k sorry for the huge delay first of all, and thank you so much for all the fixes!! I can't believe the documentation was riddled with errors that much. You probably saved me and others countless hours by fixing it! Back to this PR, I took the liberty to merge together patch-8 and patch-9 into patch-3 to have a single PR adding missing optional provider_ip fields, and also added some text for each describing what it does. |
Closed
Closed
|
Awesome! No worries for the delay! Thanks for your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.