-
-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(aws): add support to route53 simple records #715
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! It looks quite good, I just wonder if it could be achieved without using their Go SDK to rely on less dependencies (call me crazy, that's fair enough as well!)
Co-authored-by: Quentin McGaw <quentin.mcgaw@gmail.com>
* Implements the request signing version 4 * Print formatted error messages * Remove optional region to global resource * Rename config settings
* revert hardcoded ip for testing
- access key not set - secret key not set
First of all, my apologies for the long delay! Second, it was very enjoyable to review your quality Go code, congrats on that! A lot of attention to details and good work on porting code from the AWS sdk to this repo 💯
|
Yes, by their documentation, it wouldn't be a problem.
DNS was updated correctly. Everything is looking fine. Some sample from debug logs [redacted some info]
|
Perfect, thanks for the feedback, merging it 🚀 ! |
Changes
This includes the support to Simple Route policy from Route53.
Details:
Testing
Build container and ran with the default configs and using policy in the documentation
Here is one event for a domain that didn't exit at route53
Note: this is a partial implementation of #375 because AWS route53 supports many more DNS features.