Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Early exit missed? #69

Closed
mm97mm opened this issue Apr 8, 2021 · 1 comment
Closed

Early exit missed? #69

mm97mm opened this issue Apr 8, 2021 · 1 comment

Comments

@mm97mm
Copy link
Contributor

mm97mm commented Apr 8, 2021

Isn't early exit missed here? As well as below, where we refuse query to a blacklisted domain but we still go, resolve and respond with ip later?

if h.cache != nil {

if h.blist.FilterRequest(r) {

response, _, err := h.client.ExchangeWithConn(r, conn)

qdm12 added a commit that referenced this issue Apr 8, 2021
@qdm12
Copy link
Owner

qdm12 commented Apr 8, 2021

Thank you a hundred times. How did I not see that. Plus I made the copy pasta mistake on both dot and doh 🤮

It's now fixed on the branch/image tag v2.0.0-beta, I will fix it on master and v1.x.x branches later.

qdm12 added a commit that referenced this issue Apr 8, 2021
@qdm12 qdm12 closed this as completed in 0012aa9 Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants