ExpressVPN Fix #1047
ExpressVPN Fix #1047
Conversation
…ted upon in the OpenVPNConfig function. Added a check and a lines.add to iclude fragment if it's included in the provider settings. Updated the expressvpn OpenVPNConfig to include 2 additional ciphers.
There was a problem hiding this comment.
Awesome thanks!!!
Congrats on your first contribution 👍
How was your experience contributing? Did you read any webpage on this repository/wiki to help you getting started? I'm asking since I worked quite a bit recently on making the contribution journey easier (especially to add providers).
|
Thank you! It was a very pleasant experience contributing to your project. I read through the full wiki a couple times trying to troubleshoot the errors I was receiving. Troubleshooting was definitely the hardest part as I am not fully familiar with OpenVPN. I have never done anything in Go before either, but its a pretty easy language to understand, so I had fun with that! |
|
@barino28 Awesome! For future reference, you can also check out https://github.com/qdm12/gluetun/wiki/Development and https://github.com/qdm12/gluetun/tree/master/.devcontainer#development-container since this is an all-in-a-container development container tuned for Gluetun 😉 And also sorry about that fragment that got lost in translation whilst refactoring the code! |
had issues with connecting to ExpressVPN. After some troubleshooting I noticed that even though Fragment was defined in the Provider Configuration, the line was never written in the .ovpn file. Added a section to write this line if the Fragment argument was included.
Updated the ciphers that ExpressVPN needs to include AWES128gcm, and AES256gcm along with the AES256cbc cipher.
This is my first time contributing to an open source project. Let me know if there is a better way to submit these changes.