Add Splade v1 #144
Merged
Add Splade v1 #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NirantK
commented
Mar 12, 2024
Anush008
reviewed
Mar 12, 2024
Anush008
reviewed
Mar 12, 2024
generall
reviewed
Mar 12, 2024
|
Made a small refactoring to make sure we will use appropriate types for sparse embeddings. Had to move to stuff around to avoid code duplication. One last thing for this PR is to move model into qdrant HF, otherwise LGTM |
NirantK
commented
Mar 13, 2024
generall
approved these changes
Mar 13, 2024
Anush008
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds our first Sparse Vector model to FastEmbed!
We add one of the more modern implementations of SPLADE: https://huggingface.co/prithivida/Splade_PP_en_v1
This has the main advantage of being permissively licensed