Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Snowflake models #207

Merged
merged 4 commits into from
Apr 19, 2024
Merged

feat: Snowflake models #207

merged 4 commits into from
Apr 19, 2024

Conversation

Anush008
Copy link
Member

@Anush008 Anush008 commented Apr 18, 2024

Description

Adds support for https://huggingface.co/Snowflake models.

NOTE: The medium sized model is missing ONNX weights.

@Anush008 Anush008 requested a review from NirantK April 18, 2024 09:19
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Ya-shh
Copy link

Ya-shh commented Apr 18, 2024

Description

Adds support for https://huggingface.co/Snowflake models.

NOTE: The medium sized model is missing ONNX weights.

Can I push ONNX weights to medium sized model, would it help ?

@Anush008
Copy link
Member Author

Joshua(Xenova) had already contributed those. I don't see them though.
https://huggingface.co/Snowflake/snowflake-arctic-embed-m/discussions/4

@Anush008
Copy link
Member Author

@Ya-shh
Copy link

Ya-shh commented Apr 18, 2024

You're welcome! @Anush008

@Ya-shh
Copy link

Ya-shh commented Apr 18, 2024

Joshua(Xenova) had already contributed those. I don't see them though.
https://huggingface.co/Snowflake/snowflake-arctic-embed-m/discussions/4

It has been recently merged, now the model has onnx weights

Comment on lines +31 to +37
"snowflake/snowflake-arctic-embed-xs": np.array([0.0092, 0.0619, 0.0196, 0.009, -0.0114]),
"snowflake/snowflake-arctic-embed-s": np.array([-0.0416, -0.0867, 0.0209, 0.0554, -0.0272]),
"snowflake/snowflake-arctic-embed-m": np.array([-0.0329, 0.0364, 0.0481, 0.0016, 0.0328]),
"snowflake/snowflake-arctic-embed-m-long": np.array(
[0.0080, -0.0266, -0.0335, 0.0282, 0.0143]
),
"snowflake/snowflake-arctic-embed-l": np.array([0.0189, -0.0673, 0.0183, 0.0124, 0.0146]),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you've compared the Sentence Transformers and ONNX vector values here? Please add the Colab notebook or confirm with a comment here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. They're from Sentence Transformers. Upto 4 digits precision. Then off.

@NirantK NirantK merged commit cc4112d into main Apr 19, 2024
17 checks passed
@NirantK NirantK deleted the snowflake branch April 19, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants