Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add examples with supported typed of models into readme #271

Merged
merged 5 commits into from
Jun 13, 2024

Conversation

generall
Copy link
Member

No description provided.

@generall generall requested a review from joein June 11, 2024 14:19
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

README.md Outdated

```

Full list of supported models can be found [here](https://qdrant.github.io/fastembed/examples/Supported_Models/).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have this link inside Dense text embeddings, and the same link in Image Embeddings.

It made me think that this one is a link to the supported dense embeddings, and the latter one is a link to the supported image embeddings, however, both of them are links to the general list with all models.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
generall and others added 3 commits June 13, 2024 10:56
Co-authored-by: George <george.panchuk@qdrant.tech>
Co-authored-by: George <george.panchuk@qdrant.tech>
Co-authored-by: George <george.panchuk@qdrant.tech>
@joein joein self-requested a review June 13, 2024 08:56
@generall generall merged commit 29cfcda into main Jun 13, 2024
17 checks passed
@generall generall deleted the suggest-readme-updates branch June 13, 2024 08:58
Anush008 pushed a commit that referenced this pull request Jun 17, 2024
* add examples with supported typed of models into readme

* fix link

* Update README.md

Co-authored-by: George <george.panchuk@qdrant.tech>

* Update README.md

Co-authored-by: George <george.panchuk@qdrant.tech>

* Update README.md

Co-authored-by: George <george.panchuk@qdrant.tech>

---------

Co-authored-by: George <george.panchuk@qdrant.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants