Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Junit test result output #32

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Conversation

russcam
Copy link
Collaborator

@russcam russcam commented Nov 26, 2023

This commit adds junit test result output on CI, and reports test results as a pull request check.

This commit adds junit test result output on CI, and reports test
results as a pull request check.
@russcam russcam requested a review from roji November 26, 2023 06:28
Copy link
Collaborator

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not specifically familiar with Junit or this plugin...

Just in case it's interesting/useful, on Npgsql we use GitHubActionsTestLogger (it's activated like this), which automatically posts a test summary to the Github Actions build summary (e.g. like this). It seems a bit lighter in that it doesn't require write permissions to the checks or an extra workflow step.

@russcam
Copy link
Collaborator Author

russcam commented Nov 26, 2023

Just in case it's interesting/useful, on Npgsql we use GitHubActionsTestLogger (it's activated like this), which automatically posts a test summary to the Github Actions build summary (e.g. like this). It seems a bit lighter in that it doesn't require write permissions to the checks or an extra workflow step.

Nice! Can it also post the check to a PR from a fork? The JUnit report action is supposed to be able to do this, though I couldn't get the example to work

@roji
Copy link
Collaborator

roji commented Nov 26, 2023

I think this should work, yeah... Am currently traveling but will try to take a look later today/tomorrow if it's not working for you.

@russcam russcam merged commit 85503a1 into qdrant:main Dec 21, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants