RecreateCollection should not throw on non-existent collection

[russcam]

This commit fixes RecreateCollection to not throw when attempting to delete a collection that doesn't exist.

The qdrant server delete_collection function returns true when the name is removed from the collections hashmap. It may make sense in future to return Task<bool> from the DeleteCollectionAsync method of the client, mapped to the .Result on the response.

[roji]

Probably should remove this line altogether:

Suggested change

///

[roji]

Suggested change

///

[roji]

This will also swallow various unrelated exceptions (e.g. network problems - though those will presumably cause the CreateCollectionAsync below to throw as well).

Definitely sounds like a good idea to return a bool from DeleteCollecitonAsync, if qdrant returns that info...

[russcam]

I think this is only going to swallow where the service returns false in the result

qdrant-dotnet/src/Qdrant.Client/QdrantClient.cs

Lines 530 to 547 in 9f0ae2e

	try
	{
	var response = await _collectionsClient
	.DeleteAsync(
	request,
	deadline: _grpcTimeout == default ? null : DateTime.UtcNow.Add(_grpcTimeout),
	cancellationToken: cancellationToken)
	.ConfigureAwait(false);
	if (!response.Result)
	throw new QdrantException($"Collection '{collectionName}' could not be deleted");
	}
	catch (Exception e)
	{
	_logger.OperationFailed(nameof(LoggingExtensions.DeleteCollection), e);
	throw;
	}

which looks like it is only returned from the server when the collection name didn't exist in the hashmap (didn't exist at point of attempting to remove).

I do however think it makes sense to change DeleteAsync to return Task<bool>. This would be a breaking change to the API signature and to behaviour (no need to throw a QdrantException any more). What do you think about making this kind of change in a patch version @generall?

[russcam]

Will merge this as is for now

[roji]

@russcam my vote would be to keep things a bit "fluid" for now, and allow some breaking changes which makes sense, as it's an early version etc. As more people use it and report issues, the SDK will stabilize etc.