-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove overcomplicated iterator #409
Conversation
|
||
points_ids.clear(); | ||
for link in self.links(candidate.idx, level) { | ||
if !visited_list.check_and_update_visited(*link) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In theory the amount of edges for a single node could be larger than get_m
- in case we are creating additional links based in indexed payload. In this case we need to limit scoring to only the first M
points which pass the filter, even if there are more than M
point in total
Is the row 5 an outlier for the fixing trick? Anyway, it seems to be offering 15-to-20% speedup compared to the master. Yes, already tired of the holiday, returning back with full energy on Monday 😄 |
measurement latest commit with master: |
I was wondering why you got a new weird clippy error then I found this line
Looks like we are pulling the new release right away, it might make sense to lock the rust version used in the CI pipeline. |
suggested a small refactoring #450 (benchmarks are not affected) |
* remove action in filtered scorer * update comment * move filter to search and link
All Submissions:
New Feature Submissions:
cargo fmt
command prior to submission?cargo clippy
command?Changes to Core Features: