-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add custom builder for VectorsConfig #135
Conversation
self | ||
} | ||
|
||
pub fn add_vector_params(&mut self, params: impl Into<VectorParams>) -> &mut Self { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if add
is the right prefix here. It sounds to me as if you can call it multiple times. What do you think about naming it with_vector_params
or just vector_params
as the other setter functions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
then it won't be consistent with add_named_vector_params
(which is not setter), because it won't overwrite data there with non-default name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure whether it needs to be treated that similar to add_named_vector_params
because one is basically a setter and one not.
It was just a suggestion because I can imagine user getting confused by this. With the comment I think it'd be fine either way so feel free to mark this as resolved
Co-authored-by: Jojii <15957865+JojiiOfficial@users.noreply.github.com>
Co-authored-by: Tim Visée <tim@visee.me>
Co-authored-by: Tim Visée <tim@visee.me>
* add custom builder for VectorsConfig * fmt * Update src/qdrant_client/builers/vectors_config.rs Co-authored-by: Jojii <15957865+JojiiOfficial@users.noreply.github.com> * Update src/qdrant_client/builers/vectors_config.rs Co-authored-by: Tim Visée <tim@visee.me> * Update src/qdrant_client/builers/vectors_config.rs Co-authored-by: Tim Visée <tim@visee.me> * fix clippy * fix clippy --------- Co-authored-by: Jojii <15957865+JojiiOfficial@users.noreply.github.com> Co-authored-by: Tim Visée <tim@visee.me>
* add custom builder for VectorsConfig * fmt * Update src/qdrant_client/builers/vectors_config.rs Co-authored-by: Jojii <15957865+JojiiOfficial@users.noreply.github.com> * Update src/qdrant_client/builers/vectors_config.rs Co-authored-by: Tim Visée <tim@visee.me> * Update src/qdrant_client/builers/vectors_config.rs Co-authored-by: Tim Visée <tim@visee.me> * fix clippy * fix clippy --------- Co-authored-by: Jojii <15957865+JojiiOfficial@users.noreply.github.com> Co-authored-by: Tim Visée <tim@visee.me>
* add custom builder for VectorsConfig * fmt * Update src/qdrant_client/builers/vectors_config.rs Co-authored-by: Jojii <15957865+JojiiOfficial@users.noreply.github.com> * Update src/qdrant_client/builers/vectors_config.rs Co-authored-by: Tim Visée <tim@visee.me> * Update src/qdrant_client/builers/vectors_config.rs Co-authored-by: Tim Visée <tim@visee.me> * fix clippy * fix clippy --------- Co-authored-by: Jojii <15957865+JojiiOfficial@users.noreply.github.com> Co-authored-by: Tim Visée <tim@visee.me>
Allows to create vector configs like this: