Improve crate layout, mark deprecations, resolve many test warnings #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
generall
reviewed
Jun 20, 2024
generall
reviewed
Jun 20, 2024
timvisee
force-pushed
the
v1-10-refactor-1
branch
from
670e5aa
to
74ef144
Compare
generall
approved these changes
Jun 20, 2024
JojiiOfficial
approved these changes
Jun 20, 2024
timvisee
added a commit
that referenced
this pull request
Jun 26, 2024
…136) * Improve crate layout, mark deprecations, resolve many test warnings * In search example, use simplified way for client construction * Show search example output as JSON * Temporarily allow deprecation in test snippets
timvisee
added a commit
that referenced
this pull request
Jun 26, 2024
…136) * Improve crate layout, mark deprecations, resolve many test warnings * In search example, use simplified way for client construction * Show search example output as JSON * Temporarily allow deprecation in test snippets
timvisee
added a commit
that referenced
this pull request
Jun 27, 2024
…136) * Improve crate layout, mark deprecations, resolve many test warnings * In search example, use simplified way for client construction * Show search example output as JSON * Temporarily allow deprecation in test snippets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of refactoring all over the place, some key differences include:
Qdrant,QdrantConfig,Errorand other types at crate rootexamples/search.rs, kept old version inexamples/deprecated_search.rsThe current documentation can be seen by running
cargo doc --no-deps --open.It currently looks like this:
All Submissions:
devbranch. Did you create your branch fromdev?