introduce basic ops on Range
and ValuesCount
#63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces some typical operations on
Range
andValueCount
, conforms them tostd::ops::RangeBounds
and provides macros to construct them with a syntax analogous to normal Rust ranges.I'm a bit unsure about the macros for a number of reasons:
f64::INFINITY
,rustfmt
rewritesa=..=b
intoa = ..=b
,but, on the other hand, they drastically reduce the verbosity of the other ways to construct these types.
An alternative approach would be to allow construction as
From<std::ops::Range>
etc. and allow to exclude the lower bound by a separate method:The various checks for infinites and NaNs on
f64
are perhaps somewhat excessive, as these can't be expressed in JSON and thus stored in payloads, but these still can be passed intoRange
if the latter isn't constructed carefully and produce surprising query results.