Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: disabled validators in dusputes #2012

Merged
merged 12 commits into from
Apr 25, 2024

Conversation

xDimon
Copy link
Member

@xDimon xDimon commented Mar 21, 2024

Referenced issues

Resolves #2005

Description of the Change

Keep in mind disabled validators during handle dispute request votes and postpone them till dispute is not escalated by some enabled validator.

Possible Drawbacks

Lag of participation in disputes

Checklist Before Opening a PR

  1. Code is formatted: Have you run your code through clang-format to ensure it adheres to the project's coding standards? Yes
  2. Code is documented: Have you added comments and documentation to your code according to the guidelines in the project's contributing guidelines? Yes
  3. Self-review: Have you reviewed your own code to ensure it is free of typos, syntax errors, logical errors, and unresolved TODOs or FIXME without linking to an issue? No
  4. Zombienet Tests: Have you ensured that the zombienet tests are passing? Zombienet is a network simulation and testing tool used in this project. It's important to ensure that these tests pass to maintain the stability and reliability of the project. No

@xDimon xDimon force-pushed the feature/disabled_validators_in_dusputes branch from 0504d28 to cbd0fec Compare March 22, 2024 07:27
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
@xDimon xDimon force-pushed the feature/disabled_validators_in_dusputes branch from cbd0fec to d426223 Compare April 12, 2024 10:48
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
@xDimon xDimon marked this pull request as ready for review April 12, 2024 15:31
@xDimon xDimon requested review from turuslan and iceseer April 12, 2024 15:32
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
@xDimon xDimon enabled auto-merge (squash) April 25, 2024 14:27
@xDimon
Copy link
Member Author

xDimon commented Apr 25, 2024

Zombienettests still not implemented. Issue opened: #2068

@xDimon xDimon disabled auto-merge April 25, 2024 14:36
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
@xDimon xDimon force-pushed the feature/disabled_validators_in_dusputes branch from 249a712 to a4f7f3f Compare April 25, 2024 15:00
@xDimon xDimon enabled auto-merge (squash) April 25, 2024 15:01
@xDimon xDimon merged commit 396c5c6 into master Apr 25, 2024
9 of 10 checks passed
@xDimon xDimon deleted the feature/disabled_validators_in_dusputes branch April 25, 2024 15:20
@kamilsa kamilsa mentioned this pull request Jun 11, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validators disabling in dispute coordinator
3 participants