Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Fixes #2173

Merged
merged 2 commits into from
Aug 7, 2024
Merged

CI Fixes #2173

merged 2 commits into from
Aug 7, 2024

Conversation

kamilsa
Copy link
Contributor

@kamilsa kamilsa commented Aug 6, 2024

Referenced issues

None

Description of the Change

  • Clang-tidy CI step used removed clang-tidy-15, this PR updates it to clang-tidy-16
  • Zombietest 0001 used wrong metric name for kagome node

Possible Drawbacks

None

Checklist Before Opening a PR

Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item:

  1. Code is formatted: Have you run your code through clang-format to ensure it adheres to the project's coding standards? Yes
  2. Code is documented: Have you added comments and documentation to your code according to the guidelines in the project's contributing guidelines? Yes
  3. Self-review: Have you reviewed your own code to ensure it is free of typos, syntax errors, logical errors, and unresolved TODOs or FIXME without linking to an issue? Yes
  4. Zombienet Tests: Have you ensured that the zombienet tests are passing? Zombienet is a network simulation and testing tool used in this project. It's important to ensure that these tests pass to maintain the stability and reliability of the project. Yes

@kamilsa kamilsa marked this pull request as ready for review August 7, 2024 07:31
@kamilsa kamilsa merged commit e6b8485 into master Aug 7, 2024
16 of 19 checks passed
@kamilsa kamilsa deleted the fix/ci-fixes branch August 7, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants