Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scales api revamp + codegen fixes #56

Merged
merged 62 commits into from
Mar 14, 2022
Merged

Scales api revamp + codegen fixes #56

merged 62 commits into from
Mar 14, 2022

Conversation

anthonynorth
Copy link
Member

Adds flexibility to the scales api.
Changes:

  • palette, range, breaks may take generator functions
  • palette, range interpolation -- no longer need to conform to breaks / levels
  • quantize scale takes a n_breaks, instead of computing n_breaks from palette / range
  • quantile scale takes probs, instead of computing from palette / range
  • rebuilt codegen, cleaner validation errors
  • internal refactorings

@anthonynorth
add numeric ramps
d45abc9
@anthonynorth
number_categories interpolation consistent with color_categories
15b6db2
@anthonynorth
test number ramp
5e7a224
@anthonynorth
rename file
fb458c0
@anthonynorth
rename file
5f39ef2
@anthonynorth
consolidate ramp functions
75fd7b2
@anthonynorth
add mutable range helpers
640da97
@anthonynorth
revamp scales api
b6837c0
@anthonynorth
add scale compilers
6c15c0f
@anthonynorth
default breaks for numeric scales dependent on range
959e3d5
@anthonynorth
add rename util
515d400
@anthonynorth
fix lintr warning
ae9f810
@anthonynorth
scale breaks bugfixes
406fd7b 
- breaks_trans: handle null input
- breaks_log: suppress min/max warning
- compile: warn if threshold scale domain is empty
@anthonynorth
undelete util
251f5ba
@anthonynorth
Merge remote-tracking branch 'origin/master' into scales
bb1ed5d
@anthonynorth
Merge remote-tracking branch 'origin/master' into scales
36dd514
@anthonynorth
Merge remote-tracking branch 'origin/master' into scales
a1ff3c0
@anthonynorth
Merge remote-tracking branch 'origin/master' into scales
f5bab9e
@anthonynorth
refactor accessor constructor to s3
1abd801
@anthonynorth
scale col stored as string
ecdd3d1
@anthonynorth
export compilers
ad6c1ed
@anthonynorth
rewrite property validation codegen
7af3963
@anthonynorth
codegen fixes
8e30e1c
@anthonynorth
move set validation to codegen
9f39263
@anthonynorth
Merge remote-tracking branch 'origin/master' into scales
e28e14b
@anthonynorth
move set validation to codegen
fe376e3
@anthonynorth
bugfix: treating colorRange as scalar
a82b9fc
@anthonynorth
array length validation, bugfixes
ea5c674
@anthonynorth
remove dead code
e55803d
@anthonynorth
migrate all assertions to tidyassert
d437373
@anthonynorth
add accessor listtype validations
6258f3c
@anthonynorth
better error message for array props
0c7250b
@anthonynorth
error wrappers for clearer errors
e07a419
@anthonynorth
codegen fixes:
6be454b 
- optional params
- transform color param default
- wrong default name for mvt and tile layers
- use error wrappers in layer create
@anthonynorth
validation overrides for mvt layer
48880a2
@anthonynorth
bugfix: is.finite -> all(is.finite) in validators
df91e68
@anthonynorth
assertion bugfixes
cea8339
@anthonynorth
defer column exists check for accessors
db0b6c1
@anthonynorth
bugfix: conditionally validate icon/text on geojson/mvt layers
7595929
@anthonynorth
layer serialisation fixes
f53ec92
@anthonynorth
add list-mutate, refactor scale compile & to_json
245dd3d
@anthonynorth
refactor mutate
81f04de
@anthonynorth
util function rename
22d1b08
@anthonynorth
refactorings
e24051a 
- keep attrs on select
- drop pick & omit
- remove unused code
@anthonynorth
bugfix: make accessor recursive, fixes bug with name resolved from call
ffe3c57
@anthonynorth
scale bugfixes
e0923c8
@anthonynorth
bugfix: unknown_tick could be missing
349b42b
@anthonynorth
document scales api changes
76cda9b
@anthonynorth
patch vignette
a75c17e
@anthonynorth
add jsonlite
1afa454
@anthonynorth
rbuildignore contributing.md
164d724
@anthonynorth
document
72a91c2
@anthonynorth
bump dev version
ae70f27
@anthonynorth
range fixes
808a41d
@anthonynorth
Copy link
Member Author

Undocumented layer parameters are in master -- unrelated to this PR

@anthonynorth anthonynorth merged commit 523285d into master Mar 14, 2022
This was referenced Mar 17, 2022
Closed
Closed
Closed
@anthonynorth anthonynorth deleted the scales branch May 5, 2022 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@anthonynorth