Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Altium Docs #12

Merged
merged 3 commits into from
Oct 17, 2020
Merged

Update Altium Docs #12

merged 3 commits into from
Oct 17, 2020

Conversation

llim1
Copy link
Member

@llim1 llim1 commented Oct 17, 2020

More detailed additions to altium docs in preparation for the tutorials.

@ethanmpeterson ethanmpeterson added documentation Improvements or additions to documentation WIP Work In Progress labels Oct 17, 2020
ethanmpeterson
ethanmpeterson reviewed Oct 17, 2020
View reviewed changes
Copy link
Member

@ethanmpeterson ethanmpeterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Left a couple questions / comments.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@llim1 llim1 mentioned this pull request Oct 17, 2020
Closed
@llim1 llim1 linked an issue Oct 17, 2020 that may be closed by this pull request
Add Instructions for using QFSAE Altium Library to README #7
Closed
@llim1
Copy link
Member Author

llim1 commented Oct 17, 2020 •
edited
Loading

I think this is a good amount of detail for installation and set up, at least for tutorial 1.

ethanmpeterson
ethanmpeterson approved these changes Oct 17, 2020
View reviewed changes
Copy link
Member

@ethanmpeterson ethanmpeterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@llim1 llim1 merged commit dc41308 into master Oct 17, 2020
@llim1 llim1 deleted the altium-docs branch October 17, 2020 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanmpeterson ethanmpeterson ethanmpeterson approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation WIP Work In Progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Instructions for using QFSAE Altium Library to README
2 participants
@llim1 @ethanmpeterson