Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAN Transceiver PCB Review #2

Merged
merged 3 commits into from
Jul 10, 2020
Merged

CAN Transceiver PCB Review #2

merged 3 commits into from
Jul 10, 2020

Conversation

ethanmpeterson
Copy link
Member

Please check this against the design checklists proposed in the other PR.

@ethanmpeterson ethanmpeterson added the PCB For PCB Project Pull Requests label Jul 5, 2020
@ethanmpeterson ethanmpeterson self-assigned this Jul 5, 2020
Copy link
Member

@llim1 llim1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All important nets named ✔️
No 4 point connections ✔️
Short circuit protection where needed ✔️- N/A
No circuit compilation errors ✔️

2-layer board:
No DRC errors ✔️
All SMD parts on one layer ✔️
IR Calculations for high current traces ✔️ - no high current traces
Board is mechanically sound, dimensions are correct and component height does not create mechanical conflicts ✔️
IO ports and connectors double checked such that they are accessible when the board is fully assembled ✔️
No unconnected ground ✔️
Ground pour on top and bottom layers. ❌ missing top layer ground pour
Stitching vias ✔️
Length matching for high speed signals and differential pairs ✔️
Proper filter capacitor placement for MCU layout ✔️ - N/A

  • Could shorten top of board reducing length of CAN pair but not required
  • Recommend adding teardrops

@ethanmpeterson ethanmpeterson requested a review from llim1 July 8, 2020 00:55
@ethanmpeterson
Copy link
Member Author

All important nets named ✔️
No 4 point connections ✔️
Short circuit protection where needed ✔️- N/A
No circuit compilation errors ✔️

2-layer board:
No DRC errors ✔️
All SMD parts on one layer ✔️
IR Calculations for high current traces ✔️ - no high current traces
Board is mechanically sound, dimensions are correct and component height does not create mechanical conflicts ✔️
IO ports and connectors double checked such that they are accessible when the board is fully assembled ✔️
No unconnected ground ✔️
Ground pour on top and bottom layers. ❌ missing top layer ground pour
Stitching vias ✔️
Length matching for high speed signals and differential pairs ✔️
Proper filter capacitor placement for MCU layout ✔️ - N/A

  • Could shorten top of board reducing length of CAN pair but not required
  • Recommend adding teardrops

added the tear drops and left ground off the top layer since the bottom plane already provides us with a low impedance ground since there are no traces routed on the bottom layer breaking things up.

@ethanmpeterson ethanmpeterson merged commit 480a607 into master Jul 10, 2020
@ethanmpeterson ethanmpeterson deleted the can-transceiver branch July 10, 2020 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PCB For PCB Project Pull Requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants