Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the ID in plugin detail page #344

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Conversation

Xpirix
Copy link
Collaborator

@Xpirix Xpirix commented Jan 16, 2024

Changes summary:

  • Show the plugin ID under the plugin name and in the Details Tab
  • Add a button to copy the plugin ID to the clipboard

Please find below the screenshot:

image

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a9dabb5) 36.97% compared to head (ca80e10) 36.97%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #344   +/-   ##
=======================================
  Coverage   36.97%   36.97%           
=======================================
  Files         106      106           
  Lines        4500     4500           
=======================================
  Hits         1664     1664           
  Misses       2836     2836           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Guts
Copy link

Guts commented Jan 16, 2024

LGTM!

Thanks again for your quick work on this!

@Xpirix
Copy link
Collaborator Author

Xpirix commented Jan 16, 2024

You're welcome.

@dimasciput dimasciput merged commit c2b9c13 into qgis:master Jan 31, 2024
2 checks passed
@Xpirix
Copy link
Collaborator Author

Xpirix commented Feb 6, 2024

This feature has been deployed. Please feel free to check and share your feedback.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants