-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Processing help files for QGIS algs all dead now #21550
Comments
Author Name: Paolo Cavallini (@pcav) I see at least gdal and grass here, current master. |
Author Name: Anita Graser (@anitagraser) This change should only affect QGIS algs.
|
Author Name: Richard Duivenvoorde (@rduivenvoorde) I had a look into this, seems pretty easy to fix this line: https://github.com/qgis/QGIS/blob/master/python/plugins/processing/core/GeoAlgorithm.py#L141 helpUrl = 'http://docs.qgis.org/{}/en/docs/user_manual/processing_algs/{}/{}/{}.html'.format(qgsVersion, providerName, safeGroupName, safeAlgName) into helpUrl = 'http://docs.qgis.org/{}/en/docs/user_manual/processing_algs/{}/{}.html#{}'.format(qgsVersion, providerName, safeGroupName, safeAlgName) BUT: the safeAlgName is already 'cleaned', so there are no '-' in it anymore, while the anchors in the html file contain '-' EG: using the line above, you will get the following url: while the anchor in current html files are like: so EITHER we have to have a look into the 'cleaning'-up of the url-components |
Author Name: Richard Duivenvoorde (@rduivenvoorde) Paolo Cavallini wrote:
Hi Paolo, you say 'hel' you mean 'hell', like it is not working for you? Because for me grass7 is (with or without my 'patch') still working ok. GDAL is alway pointing to the same url (ogr2ogr). I think there was a discussion already about where to point for help to for these external algorithm's isn't it? |
Author Name: Paolo Cavallini (@pcav) Typo, now corrected, sorry. |
Author Name: Jürgen Fischer (@jef-n) Fixed in changeset "ca697dbaf28905660df0e12fa10ede2396c36867".
|
Author Name: Anita Graser (@anitagraser) Does this really work for you? For me, the help dialog loads the correct page but it doesn't jump to the correct heading. Tested e.g. for Reproject layer, and Fixed distance buffer.
|
Author Name: Richard Duivenvoorde (@rduivenvoorde) Anita, I had seen that too, following is an email from me to alex and victor, (we are talking about Ok, it has something to do with the anchor loading in a non visible If I add this Then it just works.... So another hack would be to reload(!) the url when a user hits the help So third hack is to do 'lazy loading' of the help, that is only load the url But to me this would be ok
|
Author Name: Victor Olaya (@volaya) Fixed in changeset "545a90de8ff7fce4a1c42bc84d289934c0502b3a".
|
Author Name: Harrissou Santanna (@DelazJ) The links in the processing algs help are NOT FOUND. Instead of http://docs.qgis.org/testing/en/docs/user_manual/processing_algs/qgis/vector_analysis_tools.html#sum-line-lengths as stated in Richard's first message, you get the following message : Tested on master ea0ce4e
|
Author Name: Victor Olaya (@volaya) can you provide more detail? I am not able to reproduce it here Moreover, the code in the changeset that I added does not modify the URL of the help file or the way the page is loaded, it just adds the scrolling mechanism. It seems to me that the server for some reason was responding with that and changed the URL when displaying the message. What do you get if you revert to a version before that changeset? Thanks!
|
Author Name: Harrissou Santanna (@DelazJ) Victor Olaya wrote:
I just open any QGIS algorithm in the Processing toolbox and went to its Help tab. Nothing special.
BTW, could the scrolling fix be backported to 2.8?
I've never succeeded building QGIS myself (on Win7 to 10) so I just use osgeo4w but I can't find how I can revert to a nightly build older than yesterday's. Any idea? |
Author Name: Anita Graser (@anitagraser) I can't reproduce the issue either (using OSGeo4W nightly). Are you sure you have the latest Processing version? Check the plugin manager. For me it says:
|
Author Name: Harrissou Santanna (@DelazJ) Indeed, Anita, I didn't have the same version. As stated in your quote, the available one is 2.10.2 and this is the one I had installed.
|
Author Name: Harrissou Santanna (@DelazJ) The Processing version i had in LTR was 2.6 (if I'm not wrong) so I update it to 2.10.2. New version was saved in \.qgis2 folder, meaning that reopening qgis master (or any other release) fetches the processing version in \.qgis2 and not the one in \osgeo\app folder. Since it's a core plugin, shipped in app folder, shouldn't updating be made over the shipped version instead of creating a new folder in \.qgis2? |
Author Name: Richard Duivenvoorde (@rduivenvoorde) @Harrissou fyi: processing is a core plugin, so when you install a version of QGIS the plugin is included in the QGIS-standard plugins folder. But when you update your plugins, and there is a newer version, the plugin is downloaded and put in your PERSONAL plugin folder. If all is ok, the plugins in your peronsal folder should shadow the ones in the standard(installation) plugin folder, so you should not see/use the 'older' one. IF there is still something wrong there (2.6 is old, and there have been issues with this in history), and you can give a clear way to describe, please create a new issue for this. |
Author Name: Harrissou Santanna (@DelazJ) Richard Duivenvoorde wrote:
This is what I understood, what I said and what I'm complaining about (it doesn't just shadow older's). see #21716 |
Author Name: Richard Duivenvoorde (@rduivenvoorde)
Original Redmine Issue: 13506
Affected QGIS version: master
Redmine category:processing/core
Assignee: Victor Olaya
Hi Victor,
as a result of this thread:
https://lists.osgeo.org/pipermail/qgis-community-team/2015-October/004293.html
we removed all old/stale help files from the webserver.
(in short: some time ago we had one helpfile per algorithm, to speed up generation of the docs we create one html file per group of algorithms)
with that it turned out that the help tab of processing were actually poining to the old url's like:
http://docs.qgis.org/testing/en/docs/user_manual/processing_algs/qgis/vector_analysis_tools/sumlinelengths.html#sum-line-lengths
whic are dead now.
These links should be:
http://docs.qgis.org/testing/en/docs/user_manual/processing_algs/qgis/vector_analysis_tools.html#sum-line-lengths
note that the html should be in it.
If not clear, let me know.
The text was updated successfully, but these errors were encountered: